Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated logger.Logf instead of Logger #1448

Open
seblaz opened this issue Sep 21, 2024 · 0 comments · May be fixed by #1449
Open

Use of deprecated logger.Logf instead of Logger #1448

seblaz opened this issue Sep 21, 2024 · 0 comments · May be fixed by #1449
Labels
bug Something isn't working

Comments

@seblaz
Copy link

seblaz commented Sep 21, 2024

Describe the bug
Some modules still use the deprecated logger.Logf funtion that has less flexibility than the new Logger.

To Reproduce

  1. Change the global logger
  2. Use k8s.GetKubernetesClientFromOptionsE
  3. The confgured global logger is not used and instead the log is written to stdout
logger.Default = logger.New(NewTerraTestLogger())
k8s.GetKubernetesClientFromOptionsE(t, options)

Expected behavior
Logs like Configuring Kubernetes client using config file... should use the configured logger.

Versions

  • Terratest version: v0.47.1
  • Environment details (Ubuntu 20.04, Windows 10, etc.): All envs
@seblaz seblaz added the bug Something isn't working label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant