Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring the parser #29

Open
gth828r opened this issue Apr 20, 2022 · 0 comments
Open

Consider refactoring the parser #29

gth828r opened this issue Apr 20, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gth828r
Copy link
Owner

gth828r commented Apr 20, 2022

Right now, the parser does both a syntactic ingestion of a program using pyparsing as well as does semantic interpretation of the parsed syntax into a pipeline. Some of the methods are quite long, and they include some code which seems unreachable.

We might want to consider splitting out the syntax and semantic parsing into separate classes with public methods and wrap those with an outer class which the user calls.

@gth828r gth828r added the enhancement New feature or request label Apr 20, 2022
@gth828r gth828r self-assigned this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant