Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not parsing leading episode number in anime #747

Open
johnpyp opened this issue May 13, 2023 · 1 comment
Open

Not parsing leading episode number in anime #747

johnpyp opened this issue May 13, 2023 · 1 comment

Comments

@johnpyp
Copy link

johnpyp commented May 13, 2023

Leading episode number in anime file gets parsed as part of the title rather than the episode when the episode number is a single digit.

Examples:

guessit "22. Nanatsu no Taizai - The Seven Deadly Sins [1080 Hi10p AAC][kuchikirukia].mkv"

For: 22. Nanatsu no Taizai - The Seven Deadly Sins [1080 Hi10p AAC][kuchikirukia].mkv
GuessIt found: {
    "episode": 22,
    "title": "Nanatsu no Taizai",
    "episode_title": "The Seven Deadly Sins",
    "screen_size": "1080p",
    "video_profile": "High 10",
    "color_depth": "10-bit",
    "audio_codec": "AAC",
    "release_group": "kuchikirukia",
    "container": "mkv",
    "type": "episode"
}

With a single digit leading number, it instead parses it as a movie:

guessit "5. Nanatsu no Taizai - The Seven Deadly Sins [1080 Hi10p AAC][kuchikirukia].mkv"

For: 5. Nanatsu no Taizai - The Seven Deadly Sins [1080 Hi10p AAC][kuchikirukia].mkv
GuessIt found: {
    "title": "5 Nanatsu no Taizai",
    "alternative_title": "The Seven Deadly Sins",
    "screen_size": "1080p",
    "video_profile": "High 10",
    "color_depth": "10-bit",
    "audio_codec": "AAC",
    "release_group": "kuchikirukia",
    "container": "mkv",
    "type": "movie"
}

Explicitly passing -t episode doesn't help unfortunately:

guessit -t episode "5. Nanatsu no Taizai - The Seven Deadly Sins [1080 Hi10p AAC][kuchikirukia].mkv"

For: 5. Nanatsu no Taizai - The Seven Deadly Sins [1080 Hi10p AAC][kuchikirukia].mkv
GuessIt found: {
    "title": "5 Nanatsu no Taizai",
    "alternative_title": "The Seven Deadly Sins",
    "screen_size": "1080p",
    "video_profile": "High 10",
    "color_depth": "10-bit",
    "audio_codec": "AAC",
    "release_group": "kuchikirukia",
    "container": "mkv",
    "type": "episode"
}
@VeNoMouS
Copy link

VeNoMouS commented Oct 27, 2023

I looked into what caused this,

https://github.com/guessit-io/guessit/blob/develop/guessit/rules/properties/episodes.py#L860

This is occurring as it's being detected as a "weak-episode" and its >= 10

@Toilal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants