meta is undefined

[mikehaas763]

I'm using latest in gulpjs/gulp#4.0. When I try to use any of the commands like gulp --tasks or when WebStorm tries to run gulp --tasks-json I get an error.

 return meta.tree;
            ^

TypeError: Cannot read property 'tree' of undefined

I can post the full stack trace if needed. This may just be a known issue because it's in the middle of development but I thought I'd at least get it logged in case not.

[phated]

I'm not getting this error, can you provide some more information?

[mikehaas763]

I couldn't reproduce this on my personal computer tonight so I'll try it on my work computer again tomorrow which is the original computer I had the problem on.

[mikehaas763]

I spent some time trying to track down the issue again. It seems to only be happening when I use a custom registry. I have a very basic custom registry which inherits from undertaker-registry.

'use strict';

var util = require('util');
var DefaultRegistry = require('undertaker-registry');

module.exports = BuildTasksRegistry;

util.inherits(BuildTasksRegistry, DefaultRegistry);
function BuildTasksRegistry() {
    DefaultRegistry.call(this);

    this.set('clean', function(done) {
        console.log('cleaning');
        done();
    });
}

My gulpfile is also very simple

'use strict';

var gulp = require('gulp');
var BuildTasksRegistry = require('./gulp/BuildTasksRegistry.js');

var buildTasks = new BuildTasksRegistry();
gulp.registry(buildTasks);

I can successfully run the command gulp clean. However, like I mentioned originally gulp --tasks results in that error being thrown.

I'm using undertaker-registry version 0.0.3
with gulpjs/gulp#4.0 branch

When I step into gulp and therefore into undertaker I notice the assignment to meta in tree.js.

var meta = metadata.get(task);

Looking at the contents of the metadata module that's being used in the line above, I can see it's simply a new instance of a WeakMap being exported. However, that WeakMap instance has never had any keys set. Therefore meta is undefined from the metadata.get(task) evaluation.

Does it look like I'm doing anything wrong or do you know what the metadata section is supposed to actually do?

[aleogr]

Same error here

[phated]

@mikehaas763 can you please check out #25 - we have a new way of defining custom tasks (in an init method on the registry). The init method receives the undertaker instance so metadata can be tracked. Please try this feature out with the https://github.com/phated/undertaker/tree/registry-init branch and let me know how things go. I want to get as many people trying it out as possible before I cut a release. Thanks.

[phated]

Specific commit 21cafaa

[phated]

@mikehaas763 pinging

[phated]

I believe this was closed by e7bf5b3 - Please reopen if changing to the init lifecycle hook doesn't solve this problem