From 77548ec5a7f6cf69529d9f7f5be8e4754cedac68 Mon Sep 17 00:00:00 2001
From: Nancy <153055234+LEIYOUSU@users.noreply.github.com>
Date: Wed, 30 Oct 2024 11:30:38 +0800
Subject: [PATCH] feat: add name existence check before creating attachment
 group and storage policy (#6959)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

#### What type of PR is this?

/area ui
/kind improvement
/milestone 2.20.x

#### What this PR does / why we need it:

在创建附件分组或者存储策略时，支持检查是否有已存在的名称。

#### Which issue(s) this PR fixes:

Fixes #6946

#### Special notes for your reviewer:

#### Does this PR introduce a user-facing change?

```release-note
在创建附件分组或者存储策略时，支持检查是否有已存在的名称。
```
---
 .../AttachmentGroupEditingModal.vue           | 10 +++++++
 .../components/AttachmentGroupList.vue        |  2 +-
 .../AttachmentPolicyEditingModal.vue          | 14 +++++++--
 .../components/AttachmentUploadModal.vue      |  9 ++++--
 ui/src/locales/en.yaml                        | 29 ++++++++++++++-----
 ui/src/locales/zh-CN.yaml                     |  4 +++
 ui/src/locales/zh-TW.yaml                     |  4 +++
 7 files changed, 60 insertions(+), 12 deletions(-)

diff --git a/ui/console-src/modules/contents/attachments/components/AttachmentGroupEditingModal.vue b/ui/console-src/modules/contents/attachments/components/AttachmentGroupEditingModal.vue
index dad1ed46d9..e419003712 100644
--- a/ui/console-src/modules/contents/attachments/components/AttachmentGroupEditingModal.vue
+++ b/ui/console-src/modules/contents/attachments/components/AttachmentGroupEditingModal.vue
@@ -50,6 +50,16 @@ const handleSave = async () => {
         group: formState.value,
       });
     } else {
+      const { data: groups } = await coreApiClient.storage.group.listGroup();
+      const hasDisplayNameDuplicate = groups.items.some(
+        (group) => group.spec.displayName === formState.value.spec.displayName
+      );
+      if (hasDisplayNameDuplicate) {
+        Toast.error(
+          t("core.attachment.group_editing_modal.toast.group_name_exists")
+        );
+        return;
+      }
       await coreApiClient.storage.group.createGroup({
         group: formState.value,
       });
diff --git a/ui/console-src/modules/contents/attachments/components/AttachmentGroupList.vue b/ui/console-src/modules/contents/attachments/components/AttachmentGroupList.vue
index b8b01d3956..7991e5f9aa 100644
--- a/ui/console-src/modules/contents/attachments/components/AttachmentGroupList.vue
+++ b/ui/console-src/modules/contents/attachments/components/AttachmentGroupList.vue
@@ -1,4 +1,5 @@
 <script lang="ts" setup>
+import HasPermission from "@/components/permission/HasPermission.vue";
 import type { Group } from "@halo-dev/api-client";
 import { IconAddCircle } from "@halo-dev/components";
 import { useQueryClient } from "@tanstack/vue-query";
@@ -25,7 +26,6 @@ const emit = defineEmits<{
 }>();
 
 const queryClient = useQueryClient();
-
 const defaultGroups: Group[] = [
   {
     spec: {
diff --git a/ui/console-src/modules/contents/attachments/components/AttachmentPolicyEditingModal.vue b/ui/console-src/modules/contents/attachments/components/AttachmentPolicyEditingModal.vue
index ec09872025..a36995dca1 100644
--- a/ui/console-src/modules/contents/attachments/components/AttachmentPolicyEditingModal.vue
+++ b/ui/console-src/modules/contents/attachments/components/AttachmentPolicyEditingModal.vue
@@ -135,9 +135,7 @@ const submitting = ref(false);
 const handleSave = async () => {
   try {
     submitting.value = true;
-
     const configMapToUpdate = convertToSave();
-
     if (isUpdateMode) {
       await coreApiClient.configMap.updateConfigMap({
         name: configMap.value.metadata.name,
@@ -149,6 +147,18 @@ const handleSave = async () => {
         policy: formState.value,
       });
     } else {
+      const { data: policies } =
+        await coreApiClient.storage.policy.listPolicy();
+      const hasDisplayNameDuplicate = policies.items.some(
+        (policy) => policy.spec.displayName === formState.value.spec.displayName
+      );
+
+      if (hasDisplayNameDuplicate) {
+        Toast.error(
+          t("core.attachment.policy_editing_modal.toast.policy_name_exists")
+        );
+        return;
+      }
       const { data: newConfigMap } =
         await coreApiClient.configMap.createConfigMap({
           configMap: configMapToUpdate,
diff --git a/ui/console-src/modules/contents/attachments/components/AttachmentUploadModal.vue b/ui/console-src/modules/contents/attachments/components/AttachmentUploadModal.vue
index f2dfc1ddce..0a6618cd6d 100644
--- a/ui/console-src/modules/contents/attachments/components/AttachmentUploadModal.vue
+++ b/ui/console-src/modules/contents/attachments/components/AttachmentUploadModal.vue
@@ -41,7 +41,9 @@ onMounted(() => {
   }
 });
 
-const handleOpenCreateNewPolicyModal = (policyTemplate: PolicyTemplate) => {
+const handleOpenCreateNewPolicyModal = async (
+  policyTemplate: PolicyTemplate
+) => {
   policyTemplateNameToCreate.value = policyTemplate.metadata.name;
   policyEditingModal.value = true;
 };
@@ -143,7 +145,10 @@ const onGroupEditingModalClose = async () => {
           @click="selectedGroupName = group.metadata.name"
         />
 
-        <AttachmentGroupBadge @click="handleOpenCreateNewGroupModal">
+        <AttachmentGroupBadge
+          :features="{ actions: false }"
+          @click="handleOpenCreateNewGroupModal"
+        >
           <template #text>
             <span>{{ $t("core.common.buttons.new") }}</span>
           </template>
diff --git a/ui/src/locales/en.yaml b/ui/src/locales/en.yaml
index 1936b5beb5..4de7d181e9 100644
--- a/ui/src/locales/en.yaml
+++ b/ui/src/locales/en.yaml
@@ -26,7 +26,9 @@ core:
       logout:
         tooltip: Logout
         title: Logout
-        description: Clicking Confirm will redirect to the logout page. Please ensure that the content you are editing is saved.
+        description: >-
+          Clicking Confirm will redirect to the logout page. Please ensure that
+          the content you are editing is saved.
       profile:
         tooltip: Profile
       visit_homepage:
@@ -598,6 +600,8 @@ core:
       fields:
         display_name:
           label: Display name
+      toast:
+        group_name_exists: Group name already exists
     group_list:
       internal_groups:
         all: All
@@ -643,6 +647,8 @@ core:
       fields:
         display_name:
           label: Display name
+      toast:
+        policy_name_exists: Storage policy name already exists
     upload_modal:
       title: Upload attachment
       filters:
@@ -666,8 +672,8 @@ core:
     empty:
       title: There are no attachments.
       message: >-
-        There are no attachments, you can try refreshing or
-        uploading attachments.
+        There are no attachments, you can try refreshing or uploading
+        attachments.
       actions:
         upload: Upload Attachment
     filters:
@@ -1457,7 +1463,9 @@ core:
         first: >-
           1. The restore process may last for a long time, please do not refresh
           the page during this period.
-        second: 2. Before performing the restore, all existing data will be cleared. Please ensure that there is no data that needs to be retained.
+        second: >-
+          2. Before performing the restore, all existing data will be cleared.
+          Please ensure that there is no data that needs to be retained.
         third: >-
           3. After the restore is completed, you need to restart Halo to load
           the system resources normally.
@@ -1673,7 +1681,9 @@ core:
       creation_label: Create {text} tag
     validation:
       trim: Please remove the leading and trailing spaces
-      password: "The password can only use uppercase and lowercase letters (A-Z, a-z), numbers (0-9), and the following special characters: !{'@'}#$%^&*"
+      password: >-
+        The password can only use uppercase and lowercase letters (A-Z, a-z),
+        numbers (0-9), and the following special characters: !{'@'}#$%^&*
     verification_form:
       no_action_defined: "{label} interface not defined"
       verify_success: "{label} successful"
@@ -1791,7 +1801,10 @@ core:
         editor_not_found: >-
           No editor found that matches the {raw_type} format. Please check if
           the editor plugin has been installed.
-        login_expired: The current session has expired. Click Confirm to go to the login page. Please ensure that the current content is saved. You can click Cancel to manually copy any unsaved content.
+        login_expired: >-
+          The current session has expired. Click Confirm to go to the login
+          page. Please ensure that the current content is saved. You can click
+          Cancel to manually copy any unsaved content.
     filters:
       results:
         keyword: "Keyword: {keyword}"
@@ -1832,7 +1845,9 @@ core:
         title: Cancel publish
       delete:
         title: Delete post
-        description: This action will move the post to the recycle bin, where it will be managed by the site administrator.
+        description: >-
+          This action will move the post to the recycle bin, where it will be
+          managed by the site administrator.
     publish_modal:
       title: Publish post
     setting_modal:
diff --git a/ui/src/locales/zh-CN.yaml b/ui/src/locales/zh-CN.yaml
index b59738465b..5ad468be78 100644
--- a/ui/src/locales/zh-CN.yaml
+++ b/ui/src/locales/zh-CN.yaml
@@ -572,6 +572,8 @@ core:
       fields:
         display_name:
           label: 名称
+      toast:
+        group_name_exists: 分组名称已存在
     group_list:
       internal_groups:
         all: 全部
@@ -607,6 +609,8 @@ core:
       fields:
         display_name:
           label: 名称
+      toast:
+        policy_name_exists: 存储策略名称已存在
     upload_modal:
       title: 上传附件
       filters:
diff --git a/ui/src/locales/zh-TW.yaml b/ui/src/locales/zh-TW.yaml
index fed0c13f2a..9fb191650f 100644
--- a/ui/src/locales/zh-TW.yaml
+++ b/ui/src/locales/zh-TW.yaml
@@ -549,6 +549,8 @@ core:
       fields:
         display_name:
           label: 名稱
+      toast:
+        group_name_exists: 分組名稱已存在
     group_list:
       internal_groups:
         all: 全部
@@ -584,6 +586,8 @@ core:
       fields:
         display_name:
           label: 名稱
+      toast:
+        policy_name_exists: 儲存策略名稱已存在
     upload_modal:
       title: 上傳附件
       filters: