Upgrade bootstrap version

[kerchner]

Ref:

• https://github.com/gwu-libraries/sfm-ui/blob/master/sfm/ui/templates/base.html
• https://getbootstrap.com/docs/4.3/migration/?origin_team=T08AFN77V

[dolsysmith]

• base.html
  • changes to navbar
• change_log.html
  • pager class deprecated
• collection_create.html
  • breadcrumb class now requires .breadcrumb-item on descendants
• collection_detail.html
  • see above for breadcrumb class
  • .panel deprecated in favor of .card classes
  • .glyphicon no longer included (?)
  • changes to .dropdown-menu implementation
  • .btn-default --> .btn-secondary
  • changes to .nav implementation
• collection_set_create.html
  • see above for .breadcrumb
• collection_set_detail.html
  • see above: .breadcrumb, .panel, .dropdown-menu, '.glyphicon, .btn-default`
• collection_set_list.html
  • see above: .nav
• collection_set_update.html
  • see above: .breadcrumb, .panel
• export_create.html
  • see above: .breadcrumb
• export_detail.html
  • see above: .breadcrumb, .panel
• harvest_detail.html
  • see above: .breadcrumb
• harvest_list.html:
  • see above: .breadcrumb, .pager
• home.html
  • see above: .panel
• monitor.html
  • see above: .panel
• profile_details.html
  • see above: .glyphicon
• seed_create.html
  • see above: .breadcrumb
• seed_detail.html
  • see above: .glpyhicon, .dropdown-menu, .panel
• seed_update.html
  • see above: .breadcrumb
  • .page-header deprecated
• terms_snippet.html
  • .well deprecated
• data_tables.js
  • pager class now pagination

[lwrubel]

Note that we use django-crispy-forms for forms creation and formatting. We're currently on 1.7.2 but should likely upgrade to 1.9.0 for bootstrap 4 support. However, upgrading to any version beyond the current one makes the seed choice fields in the export form not work. (Release notes).

This part will need attention: https://github.com/gwu-libraries/sfm-ui/blob/master/sfm/ui/forms.py#L950

[dolsysmith]

Glyphicons is no longer part of Bootstrap as of V4. The migration guide recommends the upstream version, but that appears to have an associated cost (albeit low).

[dolsysmith]

The dropdown menu for Add Collection is dropping up in Bootstrap 4. I can't quite figure out why, except that it seems to have something to do with the behavior of Popper.js (which Bootstrap 4 uses for dropdowns).

[lwrubel]

Looks like it is popping up because the menu is so long there is not enough room on the screen below the button. I'm looking at making it a little more compact since it seems like there is too much spacing in the menu after the upgrade.