Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deepspeed and RLHF causes error #529

Closed
pascal-pfeiffer opened this issue Dec 6, 2023 · 0 comments · Fixed by #592
Closed

[BUG] Deepspeed and RLHF causes error #529

pascal-pfeiffer opened this issue Dec 6, 2023 · 0 comments · Fixed by #592
Labels
type/bug Bug in code

Comments

@pascal-pfeiffer
Copy link
Collaborator

🐛 Bug

Running the default RLHF experiment with Deepspeed will fail with the following error:

Traceback (most recent call last):
File ".../train_wave.py", line 106, in
run(cfg=cfg)
File ".../train.py", line 948, in run
val_loss, val_metric = train_function(
File ".../train.py", line 484, in run_train_rlhf
train_dataloader.sampler, "set_epoch"
AttributeError: 'DeepSpeedDataLoader' object has no attribute 'sampler'
@pascal-pfeiffer pascal-pfeiffer added the type/bug Bug in code label Dec 6, 2023
@pascal-pfeiffer pascal-pfeiffer closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug in code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant