Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Update to wave 1.4.0 and add wildcard option #823

Closed
maxjeblick opened this issue Aug 14, 2024 · 0 comments · Fixed by #825
Closed

[FEATURE] Update to wave 1.4.0 and add wildcard option #823

maxjeblick opened this issue Aug 14, 2024 · 0 comments · Fixed by #825
Labels
type/feature Feature request

Comments

@maxjeblick
Copy link
Contributor

🚀 Feature

Since wave===1.4.0 it is possible to use wildcard in allowed_origins.
This allows to use llm-studio on cloud based instances that forward a local port to a https link.

It would be useful to update wave and add one of the following options

  • mention this option in README
  • add H2O_WAVE_ALLOWED_ORIGINS = "*" to the startup make command (not sure if this is security compliant)
  • create an additional make command

Motivation

Allows for seamless cloud usage, see also here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to wave 1.4.0 h2oai/h2o-llmstudio
1 participant
@maxjeblick