Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Wine Example Suggestions #23

Open
3 tasks
mtanco opened this issue Mar 25, 2021 · 1 comment
Open
3 tasks

Wine Example Suggestions #23

mtanco opened this issue Mar 25, 2021 · 1 comment
Assignees
Labels
area/documentation Documentation issue

Comments

@mtanco
Copy link

mtanco commented Mar 25, 2021

  • There has been positive feedback of the dropdownlists made from the data, but it might be nice to comment this bit more for users new to DataTable: what is the data structure of columns, etc. Maybe even make this a functions that takes a datatable object and returns a dropdownlist or picker
# Get a list of unique values of a particular column and prepare choices for dropdown component
features = ['country', 'price', 'province', 'region_1', 'variety', 'winery']
columns = {f: dt.unique(df[f]).to_list()[0] for f in features}
choices = {key: [ui.choice(str(item)) for item in columns[key] if item] for key in columns}
  • When someone filters by region, it would be nice to show how to filter the other drop down items appropriately

  • AutoML is ran every time someone starts the app, it might be nice to add the save_model and get_model features as part of this demo which would also reduce run time if a model already exists.

@mtanco mtanco added the area/documentation Documentation issue label Mar 25, 2021
@geomodular
Copy link
Collaborator

Thanks, @mtanco! This feedback made my day :). Will look at this.

@geomodular geomodular added this to the v0.4.0 milestone Apr 9, 2021
@geomodular geomodular self-assigned this Apr 9, 2021
@geomodular geomodular modified the milestones: v0.4.0, v0.5.0 Apr 19, 2021
@geomodular geomodular modified the milestones: v0.5.0, v0.6.0 Apr 27, 2021
@geomodular geomodular modified the milestones: v0.6.0, v0.7.0 May 7, 2021
@geomodular geomodular removed this from the v0.7.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/documentation Documentation issue
Projects
None yet
Development

No branches or pull requests

2 participants