-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload Component ( Enhancement ) #1049
Comments
We have revamped the upload component also in the wave style guide. We need to enhance this component and include this in the sdk . Thanks Martin. |
@sandruparo the proposed design is missing a few parts, please include:
|
@mturoci I'll update those states. X is a close icon use to remove file if user want. |
@mturoci you can view the component here |
Thanks @shihan007, what about the rest of the points?
|
I have added a text below browse button
You mean user cannot upload multiple files? |
I thought this is supposed to be a label, e.g.
Yes |
yeah
We can add " select one file at a time" text to above text. And if user still chooses multiple file to upload lets display an error msg as shown " Error uploading multiple files, please select one file". |
Overall UX is odd. Ideally we should prevent user from experiencing what he can or cannot do himself. It's better to restrict actions so that it's impossible to do the wrong thing. If such restrictions are not possible though, at least inform the user in advance. Having all the info in a single simple label feels too much to me + this assumes app devs will handle that themselves which I doubt. Let's try a different approach - try to think about placing these restrictions somewhere, separate from the label, so that they are visible and don't require dev interaction at all - they will be auto-populated based on chosen attributes.
As mentioned above, it's best to restrict invalid action completely so that user doesn't need to learn "the hard way". What about hiding whole drag&drop box after a single file was uploaded? Another issue is that displaying uploaded files like this can cause layout shifts or even scrollbars which is usually unwanted. |
@mturoci yeah agree with you. As you suggesting we can display text on top of the component, But still user allowed to do so. Hiding drag and drop is a good idea but what if user want to re upload a file? In normal user behaviour they tend to drag and drop or browse right way. They may not read the instructions at all. From our end it is good to restrict user from choosing other types if those are not allowed. And if user upload a file that exceed our mentioned file size we have to display an error we cannot expect user will follow instruction all the time by scanning file sizes. My opining is it doesn't matter where we display our instructions. |
Not sure what you mean.
Either add a button that would "reset" whole component or maybe better first require to remove the previous file, if no uploaded file is present, display D&D
It for sure will not be noticed in the label, but giving it some color and prominency (e.g. some color tag in top right corner with something like |
The text was updated successfully, but these errors were encountered: