Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public/Private dir mapping #1502

Closed
mturoci opened this issue Jun 15, 2022 · 0 comments
Closed

Public/Private dir mapping #1502

mturoci opened this issue Jun 15, 2022 · 0 comments
Assignees
Labels
docs Documentation

Comments

@mturoci
Copy link
Collaborator

mturoci commented Jun 15, 2022

Currently, our docs say

-public-dir value
        additional directory to serve files from, in the format "[url-path]:[filesystem-path]", e.g. "/public/files/:/some/local/path" will host /some/local/path/foo.txt at /public/files/foo.txt; multiple directory mappings allowed

and uses : as separator between remove/local. However, in code we split on @.

What should be the correct separator so that I know whether to fix code or docs @lo5? I assume docs :)

TODO: Add a note about case when running wave server via wave run - the path is not relative to where wave run is called from, but to where it the server is located, which should be venv so each path needs to start with ../ to move up from venv and get into project root.

@mturoci mturoci added the docs Documentation label Jun 15, 2022
@mturoci mturoci self-assigned this Jul 8, 2022
@mturoci mturoci closed this as completed in 5522372 Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

No branches or pull requests

1 participant