Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pipeline work for 454 data #6

Open
kifeonu opened this issue May 19, 2020 · 6 comments
Open

Make pipeline work for 454 data #6

kifeonu opened this issue May 19, 2020 · 6 comments
Labels
DSL2 Prioritize for DSL2 implementation enhancement New feature or request

Comments

@kifeonu
Copy link

kifeonu commented May 19, 2020

Make provision to use this pipeline to process 454 data

@cjfields
Copy link
Contributor

@cjfields
Copy link
Contributor

See also: benjjneb/dada2#795

@wbazant
Copy link
Contributor

wbazant commented Nov 30, 2021

I think this issue can be closed now! To process 454 data, one can add flags

--dadaOpt.HOMOPOLYMER_GAP_PENALTY -1 --dadaOpt.BAND_SIZE 32

to Nextflow, which will run dada as

dada(..., HOMOPOLYMER_GAP_PENALTY=-1, BAND_SIZE=32)

recommended in the tutorial.

@cjfields
Copy link
Contributor

@wbazant any ideas on test data sets for this one? We could add it to CI testing (which will be critical to have in place for DSL2 work)

@cjfields cjfields added the enhancement New feature or request label Nov 30, 2021
@wbazant
Copy link
Contributor

wbazant commented Nov 30, 2021

Right, since TADA doesn't do single end now, the added dadaOpt.XXX feature adds support only hypothetical paired-end 454 data, which is not even a thing in the 454 technology!

For single end 454, SRS607719 is a stool sample containing mostly E.coli, we have it under https://microbiomedb.org/mbio/app/record/sample/MBSMPL0020-7-1 .

It weighs about 1MB, and it's available from
ftp.sra.ebi.ac.uk/vol1/fastq/SRR128/009/SRR1288519/SRR1288519.fastq.gz

@cjfields
Copy link
Contributor

cjfields commented Oct 7, 2022

@wbazant I added some prelim single-end read support, including via a sample sheet. Also supports PacBio (which we can set using the --platform parameter. So this should feasibly support 454 out of the box, though we may want to have some presets for this and PacBio added at some point.

@cjfields cjfields added the DSL2 Prioritize for DSL2 implementation label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DSL2 Prioritize for DSL2 implementation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants