Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ringing artifacts #7

Open
CptPotato opened this issue Jul 12, 2024 · 0 comments
Open

Ringing artifacts #7

CptPotato opened this issue Jul 12, 2024 · 0 comments

Comments

@CptPotato
Copy link

CptPotato commented Jul 12, 2024

I'm getting some ringing artifacts with tony, especially noticeable in light grey gradients:

image
right side with increased contrast

At first I thought that I integrated the tone mapper incorrectly, but it seems like these artifacts are part of the LUT. If I pass a neutral LUT to the tone mapping shader, the artifacts are gone.

As a (very) crude workaround I refitted the LUT to an approximate luminance, which gets rid of the ringing but changes the tone mapper's look a bit:

Edit: The workaround turned out to be quite off on highly saturated colors.

PS: thanks for sharing this neat tone mapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant