Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS helper classes #1475

Closed
wants to merge 1 commit into from
Closed

Remove CSS helper classes #1475

wants to merge 1 commit into from

Conversation

drublic
Copy link
Member

@drublic drublic commented Nov 13, 2013

The following CSS helper classes get removed from main.css:

  • Image replacement: .ir
  • Hidden elements: .hidden
  • Visually hidden elements: .visuallyhidden
  • Visually hidden elements that are focussable via keybord:
    .visuallyhidden.focusable
  • Invisible elements: .invisible
  • Clearfix: .clearfix

These classes were removed because they don't provide enough use cases within
modern web development. Cases are mostly handled indiviually by developers.

All the helper code is retained in the v4 branch.

Reference #1472.

Please feel free to provide feedback and discuss this commit here.

drublic added a commit that referenced this pull request Nov 13, 2013
The following CSS helper classes get removed from `main.css`:

* Image replacement: `.ir`
* Hidden elements: `.hidden`
* Visually hidden elements: `.visuallyhidden`
* Visually hidden elements that are focussable via keybord: `.visuallyhidden.focusable`
* Invisible elements: `.invisible`
* Clearfix: `.clearfix`

These classes were removed because they don't provide enough use
cases within modern web development. Cases are mostly handled
indiviually by developers.

All code is provided in branch
[`v4`](https://github.com/h5bp/html5-boilerplate/tree/v4).

Reference #1472.
Closes #1475.

## Helper Classes

With HTML5 Boilerplate v5 we decided to remove all helper classes in CSS

This comment was marked as abuse.

This comment was marked as abuse.

@TheDutchCoder
Copy link

I'm curious what the lack of use-cases for 'visuallyhidden' are, because I've used it in every project so far.
Mainly for the implied sectioning elements (like aside) that need a heading, but that's not always (read: often) provided in a design.

The 'visuallyhidden' class makes sure the page keeps it semantic value and exposes these elements to screen readers.

They're small classes anyway and since HTML5 BP is "delete key friendly" is it really that much of a deal to leave them in?

@necolas
Copy link
Member

necolas commented Nov 14, 2013

Yeah, you're right, visuallyhidden, hidden and clearfix are all useful.

@webhat
Copy link

webhat commented Nov 14, 2013

I use clearfix, hidden and invisible quite often and won't like to see them go.

@necolas
Copy link
Member

necolas commented Nov 14, 2013

This was not an issue after all - #1472

We could close this.

@alrra
Copy link
Member

alrra commented Nov 14, 2013

I personally use all of them except .ir. So 👍 on removing .ir and 👎 on removing the other ones.

@drublic
Copy link
Member Author

drublic commented Nov 14, 2013

Sounds like a better idea to just remove .ir, as @alrra states.

@LukeAskew
Copy link

👍 for just removing .ir. Feels dated.

This class was removed because it doesn't provide enough use
cases within modern web development. Cases are mostly handled
indiviually by developers.

Reference #1472.
Closes #1475.
@drublic drublic closed this in f1a8e91 Nov 18, 2013
@drublic
Copy link
Member Author

drublic commented Nov 18, 2013

Thanks for the valuable input everyone.

@drublic drublic deleted the remove-helper branch November 18, 2013 22:40
kcmckell pushed a commit to kcmckell/html5-boilerplate that referenced this pull request Feb 25, 2014
This class was removed because it doesn't provide enough use
cases within modern web development. Cases are mostly handled
indiviually by developers.

Reference h5bp#1472.
Closes h5bp#1475.
@philklc
Copy link

philklc commented Apr 15, 2014

I still use .ir all the time. Using web fonts for text in languages with a large font size (from a few to twenty-several MBs) such as Chinese, Japanese and Korean is simply not acceptable in real-world situations, .ir is still very useful in this case to display better looking headings to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants