-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CSS helper classes #1475
Conversation
The following CSS helper classes get removed from `main.css`: * Image replacement: `.ir` * Hidden elements: `.hidden` * Visually hidden elements: `.visuallyhidden` * Visually hidden elements that are focussable via keybord: `.visuallyhidden.focusable` * Invisible elements: `.invisible` * Clearfix: `.clearfix` These classes were removed because they don't provide enough use cases within modern web development. Cases are mostly handled indiviually by developers. All code is provided in branch [`v4`](https://github.com/h5bp/html5-boilerplate/tree/v4). Reference #1472. Closes #1475.
|
||
## Helper Classes | ||
|
||
With HTML5 Boilerplate v5 we decided to remove all helper classes in CSS |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
I'm curious what the lack of use-cases for 'visuallyhidden' are, because I've used it in every project so far. The 'visuallyhidden' class makes sure the page keeps it semantic value and exposes these elements to screen readers. They're small classes anyway and since HTML5 BP is "delete key friendly" is it really that much of a deal to leave them in? |
Yeah, you're right, |
I use |
This was not an issue after all - #1472 We could close this. |
I personally use all of them except |
Sounds like a better idea to just remove |
👍 for just removing |
Thanks for the valuable input everyone. |
I still use |
The following CSS helper classes get removed from
main.css
:.ir
.hidden
.visuallyhidden
.visuallyhidden.focusable
.invisible
.clearfix
These classes were removed because they don't provide enough use cases within
modern web development. Cases are mostly handled indiviually by developers.
All the helper code is retained in the
v4
branch.Reference #1472.
Please feel free to provide feedback and discuss this commit here.