Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5-boilerplate_v7.3.0.zip is not HTML5 Boilerplate v7.3.0 #2180

Closed
1 of 3 tasks
stordoff opened this issue Dec 24, 2019 · 2 comments
Closed
1 of 3 tasks

html5-boilerplate_v7.3.0.zip is not HTML5 Boilerplate v7.3.0 #2180

stordoff opened this issue Dec 24, 2019 · 2 comments

Comments

@stordoff
Copy link

stordoff commented Dec 24, 2019

I'm submitting a ...

  • bug report
  • feature request
  • other (Please do not submit support requests here (below))

Basically, as title - html5-boilerplate_v7.3.0.zip from the GitHub releases page does not contain HTML5 Boilerplate v7.3.0. Downloading the zip (https://github.com/h5bp/html5-boilerplate/archive/v7.3.0.zip) from the tags page works fine.

Steps to reproduce:

  1. Navigate to https://github.com/h5bp/html5-boilerplate/releases
  2. Download html5-boilerplate_v7.3.0.zip (https://github.com/h5bp/html5-boilerplate/releases/download/v7.3.0/html5-boilerplate_v7.3.0.zip)
  3. Inspect contents

Signs:

main.css opens with:

/*! HTML5 Boilerplate v7.2.0 | MIT License | https://html5boilerplate.com/ */

Shipped Modernizr is modernizr-3.7.1.min.js, contradicting:

Updated to Modernizr 3.8

Oddly, some of the mentioned changes (such as #2155) do appear to have made it in, so I'm unclear what "version"/state this zip actually represents.

Edit: I've just diffed the two, and there are a few minor changes to .editorconfig. The releases page version includes:

[*.md]
trim_trailing_whitespace = false

And the documentation is missing a few updates (removing references Google+ and Bootstrap; updated links) as well.

@roblarsen
Copy link
Member

The tagged version is just a snapshot of the repo at that point. I generate that download file manually and simply messed up the contents. I need to automate that to get operator error out of the way.

I updated the zip file with the proper contents. Hopefully that will be reflected properly in the downloads going forward.

@stordoff
Copy link
Author

Fair enough - I've just re-downloaded to double-check and all looks good now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants