-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open Graph Metadata to the index.html #2211
Comments
@coliff 👇 ? <meta property="og:title" content="" />
<meta property="og:type" content="" />
<meta property="og:url" content="" />
<meta property="og:image" content="" /> Are empty values harmful? |
Interesting question! Really, we should do a proper deep dive and research into this and make sure we've got this 100% right before adding. In my quick testing, empty values fallback to standard |
Context for this as we try to get the release out the door- we ship stuff without required values (title, html lang attribute) all the time, so I'm not against shipping this if there's some negative to someone downstream shipping code without required values for these elements. |
(Tweeted) |
How about shipping them commented? <!---
Please ensure the following before you uncomment:
- that all titles are unique
- the og:type for your document is semantically correct (See ...)
- the URL is canonically correct and is set uniquely
-->
<!---
<meta property="og:title" content="" />
<meta property="og:type" content="" />
<meta property="og:url" content="" />
<meta property="og:image" content="" />
--> I think |
@coliff writes:
The text was updated successfully, but these errors were encountered: