Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Graph Metadata to the index.html #2211

Closed
roblarsen opened this issue Apr 13, 2020 · 5 comments · Fixed by #2235
Closed

Add Open Graph Metadata to the index.html #2211

roblarsen opened this issue Apr 13, 2020 · 5 comments · Fixed by #2235
Milestone

Comments

@roblarsen
Copy link
Member

@coliff writes:

This had been suggested long ago and decided against, but since then Opengraph metadata is used in many more places. It's used in previews in many messenger apps including Facebook Messenger, Apples Messages app, Slack and more social media services. I think adding Opengraph metadata is always a good idea - unless your site/app is not public at all/behind a Firewall/login etc)

@roblarsen roblarsen added this to the 8.0 milestone Apr 13, 2020
@roblarsen
Copy link
Member Author

@coliff 👇 ?

<meta property="og:title" content="" />
<meta property="og:type" content="" />
<meta property="og:url" content="" />
<meta property="og:image" content="" />

Are empty values harmful?

@coliff
Copy link
Member

coliff commented Apr 22, 2020

Interesting question! Really, we should do a proper deep dive and research into this and make sure we've got this 100% right before adding. In my quick testing, empty values fallback to standard meta description and title tags in some systems, but not in others. There are so many systems and they work differently... so let's not proceed with this just yet.
Interesting links:

@roblarsen
Copy link
Member Author

roblarsen commented Apr 26, 2020

Context for this as we try to get the release out the door- we ship stuff without required values (title, html lang attribute) all the time, so I'm not against shipping this if there's some negative to someone downstream shipping code without required values for these elements.

@roblarsen roblarsen changed the title Add OpenGraph Metadata to the index.html Add Open Graph Metadata to the index.html Apr 26, 2020
@roblarsen
Copy link
Member Author

(Tweeted)

@captn3m0
Copy link

How about shipping them commented?

<!---
Please ensure the following before you uncomment:
- that all titles are unique
- the og:type for your document is semantically correct (See ...)
- the URL is canonically correct and is set uniquely
-->
<!---
<meta property="og:title" content="" />
<meta property="og:type" content="" />
<meta property="og:url" content="" />
<meta property="og:image" content="" />
-->

I think og:image might be one where a default (uncommented) value might make sense? A single og-image across a website is a common/okay enough - kinda like favicons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants