Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Latest Export Button UI #1785

Closed
13 tasks done
ryanfchase opened this issue Jun 26, 2024 · 11 comments · Fixed by #1804
Closed
13 tasks done

Implement Latest Export Button UI #1785

ryanfchase opened this issue Jun 26, 2024 · 11 comments · Fixed by #1804
Assignees
Labels
p-feature: data P-feature: Map Pre-Launch Describes an issue that must be completed in order to launch Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours
Milestone

Comments

@ryanfchase
Copy link
Member

ryanfchase commented Jun 26, 2024

Overview

We need to implement UI elements that allow users to export selected data on to their devices since we do not officially have a way of utilizing our data export feature.

Note

Handoff documents will contain a version of the Search and Filters modal that DO NOT MATCH what we have implemented. We are to implement only the UI elements relevant to this feature

  • I understand

Action Items

  • Add export button at bottom of Search and Filters Modal
  • Error modal is displayed on Export Button click when criteria is not met
    • More than 1 request type is selected
    • No request types selected
    • No NC is selected
  • NC selected + 1 request type selected begins data export on Export Button click
    • data downloading modal appears
    • data download success modal appears if data download succeeds
    • data download failed modal appears if download failed

Resources/Instructions

Screenshot of Figma Overview

image

Screenshot after implemented changes

image

image

image

image

image

image

image

@ryanfchase ryanfchase added Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours P-feature: Map ready for dev lead ready for developer lead to review the issue p-feature: data draft labels Jun 26, 2024
@ryanfchase ryanfchase added this to the 04 - Map Page milestone Jun 26, 2024
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: 311: Project Board Jun 26, 2024
@ryanfchase ryanfchase removed the draft label Jun 26, 2024
@Skydodle
Copy link
Member

Ticket is ready to picked up.

@Skydodle Skydodle added ready for prioritization and removed ready for dev lead ready for developer lead to review the issue labels Jun 27, 2024
@Skydodle Skydodle moved this from New Issue Approval to Prioritized Backlog (ready to be assigned) in P: 311: Project Board Jun 27, 2024
@ryanfchase ryanfchase added the Pre-Launch Describes an issue that must be completed in order to launch label Jun 27, 2024
@kdow kdow self-assigned this Aug 17, 2024
@kdow
Copy link
Member

kdow commented Aug 17, 2024

ETA: 8/23
Availability: Mon-Fri 1pm-6pm

@kdow
Copy link
Member

kdow commented Aug 20, 2024

Are the needed icons available somewhere as assets or names in a font/icon library? I found some that look similar in Material UI's library (https://mui.com/material-ui/material-icons/?query=error&selected=Warning, https://mui.com/material-ui/material-icons/?query=check&selected=CheckCircle), but I haven't found exact matches for some of the others (export icon, info tooltip in notice message, document download icon in confirmation dialog).

@kdow kdow moved this from In progress to Questions in P: 311: Project Board Aug 20, 2024
@ryanfchase ryanfchase added the ready for dev lead ready for developer lead to review the issue label Aug 21, 2024
@ryanfchase
Copy link
Member Author

ryanfchase commented Aug 21, 2024

I've added ready for dev lead tag to designate that this still needs attention. (thank you for moving it to the Questions column). I will try and get this addressed by tonight's meeting. Or work with a designer to get an answer at that time.

@ryanfchase
Copy link
Member Author

ryanfchase commented Aug 21, 2024

@kdow

Are the needed icons available somewhere as assets or names in a font/icon library? I found some that look similar in Material UI's library (https://mui.com/material-ui/material-icons/?query=error&selected=Warning, https://mui.com/material-ui/material-icons/?query=check&selected=CheckCircle), but I haven't found exact matches for some of the others (export icon, info tooltip in notice message, document download icon in confirmation dialog).

Actually I think you can download all the relevant assets directly off the team Figma. I believe you can go to the Export Link and Download Process section, find the "Assets" section, and download those assets directly via Figma.

@Joy-Truex @kiranofans please let me know if there is a better way to approach this. Downloading directly off Figma seems to be our process at the moment.

Screenshot of assets

image

@kiranofans
Copy link
Member

kiranofans commented Aug 21, 2024

Are the needed icons available somewhere as assets or names in a font/icon library? I found some that look similar in Material UI's library (https://mui.com/material-ui/material-icons/?query=error&selected=Warning, https://mui.com/material-ui/material-icons/?query=check&selected=CheckCircle), but I haven't found exact matches for some of the others (export icon, info tooltip in notice message, document download icon in confirmation dialog).

Yes you can directly download frame/image from Figma in various format and size:
-> Open Figma -> find the icons or widgets -> single click on the icons or double click the icons that are on Widgets -> on your right hand you will see a panel -> at the bottom of the panel, there's a Export section -> click on Preview to expand the icon/image/widget download preview -> Click the "+" button beside Export to add one Export setting including image format and resolution/size as shown in the screenshot below:

image

Download Preview:

image

Click on the image format drop down to select an appropriate one, then click on Export Frame/default to download it.

You can also click on a widget frame (double-click an image/icon on a widget frame), then right-click and select Copy/Paste as. From there, choose Copy as SVG, Copy as PNG, or Copy as Code (CSS, iOS, Android). You can then paste the SVG/PNG directly, or paste the code wherever it applies.

image image

And I will add the icons to design system

@ryanfchase
Copy link
Member Author

@kiranofans this is a very good guide, thank you. I'm going to make a note in our agenda about adding this to our wiki

@ryanfchase
Copy link
Member Author

@kdow if your question has been answered, please move back to in progress. I will review this in breakout rooms to confirm.

@ryanfchase ryanfchase removed the ready for dev lead ready for developer lead to review the issue label Aug 21, 2024
@kdow kdow moved this from Questions to In progress in P: 311: Project Board Aug 22, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done (without merge) in P: 311: Project Board Aug 22, 2024
@kiranofans kiranofans moved this from Done (without merge) to In progress in P: 311: Project Board Aug 22, 2024
@kiranofans
Copy link
Member

I'm sorry I was trying to delete the comment (which I haven't sent yet) but I didn't notice why I closed this ticket. I have already changed it back to In Progress.

@kiranofans kiranofans reopened this Aug 22, 2024
@github-project-automation github-project-automation bot moved this from In progress to New Issue Approval in P: 311: Project Board Aug 22, 2024
@ryanfchase
Copy link
Member Author

ryanfchase commented Aug 22, 2024

@kiranofans @kdow I'll move this back to In Progress, since that seems to be the latest desired state

@ryanfchase ryanfchase moved this from New Issue Approval to In progress in P: 311: Project Board Aug 22, 2024
@ryanfchase
Copy link
Member Author

Adding my review today ETA 3~4pm

@kdow kdow closed this as completed in #1804 Sep 3, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done (without merge) in P: 311: Project Board Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-feature: data P-feature: Map Pre-Launch Describes an issue that must be completed in order to launch Role: Frontend React front end work Size: 3pt Can be done in 13-18 hours
Projects
Status: Done (without merge)
Development

Successfully merging a pull request may close this issue.

4 participants