Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Validation - Event Link #1364

Closed
3 of 4 tasks
heyitsalexander opened this issue Mar 28, 2023 · 5 comments
Closed
3 of 4 tasks

Form Validation - Event Link #1364

heyitsalexander opened this issue Mar 28, 2023 · 5 comments

Comments

@heyitsalexander
Copy link
Member

heyitsalexander commented Mar 28, 2023

Overview

Currently, the Recurring Event add/edit screen does not have any validation for the Event Link. Zoom or Google Meet links must be validated so that users know what to insert into the field and inputs are uniform across all projects.

Action Items:

To replicate:

  1. Go to a project
  2. Under Recurring Events, click "Create New Event"
  3. See "Event Link"
  4. Try adding a test event (don't forget to name it "test")
    1. Event name required
    2. Event Type required
    3. Day of the Week required
    4. Start Time required
    5. Duration required
    6. Description is optional
    7. Event link required

Validation:

Placeholder message:

  • User should be changed from "Enter meeting url..." to: "Insert Zoom or Google Meet Link"

Error message:

  • "Your link must start with https://" (if link does not include "https://")
  • "This does not look like a valid Zoom or Google Meet link" (if link does not include: "meet.google.com/" or "zoom.us/")
Screenshot 2023-08-03 at 6 43 10 PM
@heyitsalexander heyitsalexander changed the title Form Validation - Location Add New Project Field - Location Apr 11, 2023
@heyitsalexander
Copy link
Member Author

heyitsalexander commented Apr 11, 2023

@MattPereira not sure what the best way to add in some form of validation here for zoom links would be?
Sample Zoom link: https://us02web.zoom.us/j/87300266029?pwd=OUc0NFRoV2piWmp6TWZMMVE2Nk9NQT09

Could we add in a requirement so that the link has to start with https://us02web.zoom.us/* ?
If validation for all these fields is going to be too complicated, we can just stick with the placeholder text to help guide our users.

@MattPereira
Copy link
Contributor

Could we add in a requirement so that the link has to start with https://us02web.zoom.us/* ?

@heyitsalexander Yes this is possible but im not sure if zoom moves around the 02 or some other part of the url so it could potentially cause problems down the road if zoom changes url or another org has meetings that are like https://us06web.zoom.us

Off top of my head safest option zoom link might be just making sure the string entered contains zoom.us

@jbubar
Copy link
Member

jbubar commented Aug 3, 2023

Here is a pr that is not going to be merged that has some useful code on it for this validation

@JackHaeg
Copy link
Member

JackHaeg commented Sep 8, 2023

Still need to add validation for:

  • meet.google.com/ either/or zoom.us/

@JackHaeg
Copy link
Member

JackHaeg commented Sep 8, 2023

Closing as planned, covered by other tickets.

@JackHaeg JackHaeg moved this to Final QA (product) in P: VRMS: Project Board Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Final QA (product)
Development

Successfully merging a pull request may close this issue.

8 participants