Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default form values for Edit on Save so that Unsaved Changes is triggered #1576

Closed
5 tasks done
trillium opened this issue Feb 6, 2024 · 6 comments
Closed
5 tasks done

Comments

@trillium
Copy link
Member

trillium commented Feb 6, 2024

Reference #1566

Overview

When Save is pressed, tell the system that the new current baseline for the fields is the saved state. This prevents the You have unsaved changes box from popping up

Action Items

  • When Save is triggered, update the form to use the updated values as the current validation for Close/Save
  • Also potentially get the info back from the db and update the form with the new data.
  • QA
  • When complete, go to Epic: Project Edit Save #1598 and mark the checkbox referencing this issue as complete.
  • Once this issue is complete, Create loading state for save buttons on forms related to projects #1574 can be moved from the Icebox back to the top of the Priority Backlog and the Dependency label can be removed.
@trillium trillium added this to the 04.01 Existing Features milestone Feb 6, 2024
@JackHaeg JackHaeg changed the title Update defualt form values for Edit on Save so that Unsaved Chagnes is triggered Update defualt form values for Edit on Save so that Unsaved Changes is triggered Feb 6, 2024
@JackHaeg JackHaeg changed the title Update defualt form values for Edit on Save so that Unsaved Changes is triggered Update default form values for Edit on Save so that Unsaved Changes is triggered Feb 11, 2024
@JackHaeg JackHaeg mentioned this issue Feb 28, 2024
3 tasks
@JackHaeg
Copy link
Member

JackHaeg commented Mar 5, 2024

@josiehandeveloper Please provide update:

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@josiehandeveloper
Copy link
Member

Screen.Recording.2024-03-11.at.6.14.27.PM.mov

Blockers: I can't seem to recreate the issue

@JackHaeg
Copy link
Member

JackHaeg commented Mar 12, 2024

@josiehandeveloper typically, after editing an event > clicking "save" > click "close" and the You have unsaved changes box pops up (despite already saving one's edits). Please try the same process and then click "close" to replicate the issue.

@JackHaeg
Copy link
Member

@josiehandeveloper See attached (recreated the issue on Dev)

Save.Issue.mov

@josiehandeveloper
Copy link
Member

So I made some changes now after you hit save and then close you don't have the popup, but even when you click edit mode even if you don't make changes the popup comes up

Screen.Recording.2024-03-18.at.4.45.12.PM.mov

@josiehandeveloper
Copy link
Member

josiehandeveloper commented Mar 19, 2024

New fix for close button bug, committed to my last PR

Screen.Recording.2024-03-18.at.8.27.09.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Final QA (product)
Development

No branches or pull requests

3 participants