added MUI modal to edit meeting times #1741
Open
+61
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
jng34
reviewed
Oct 30, 2024
There was a problem hiding this comment.
@nora-zajzon,
This looks great! The open & close functionalities work as expected.
Just a note:
- In mobile view: The
Modalcomponent in landscape mode does not seem to be adaptive on various mobile devices, such as the Samsung Galaxy and iPhone (see screenshots below). Perhaps usingGridorContainermay fix this? - Ref: MUI Responsive UI
Screenshots in mobile landscape mode
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1724
What changes did you make and why did you make them ?
Visuals before changes are applied
Visuals after changes are