Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code auto-correct missing periods and capitalizations #1363

Closed
1 task done
SamHyler opened this issue Apr 26, 2024 · 7 comments · Fixed by #1407 or #1468
Closed
1 task done

Code auto-correct missing periods and capitalizations #1363

SamHyler opened this issue Apr 26, 2024 · 7 comments · Fixed by #1407 or #1468
Assignees
Labels
feature: letter generator issue level I: request Smallest type of issue; Typically can be completed by one person priority: medium role: development anything related to code size: 1pt can be done in 6 hours or less Status: Update Requested

Comments

@SamHyler
Copy link
Member

SamHyler commented Apr 26, 2024

Overview

The LG has some instances where the user should write sentences. The user may or may not add a period at the end of the sentence. In all the spaces users enter words, they may or may not capitalize the first word of a sentence (or possibly proper nouns).

This issue is to build automatic detection for these instances, and to automatically correct them.

Action Items

  • Code a solution that identifies and fixes sentences missing capitalization or ending periods.

Resources/Notes

  • In the LG flow, we'd want this to execute after the user enters the answer, but before the text preview.
@SamHyler SamHyler added role: development anything related to code priority: medium role: UX content writing size: 3pt Can be done in 13-18 hours feature: letter generator ready for dev lead task ready for dev lead to evaluate issue level II: main issue tracking level I issues; often will be tracking cross-fuctional teams tasks ready for content lead labels Apr 26, 2024
@SamHyler SamHyler added this to the Stakeholder Review 2.0 milestone Apr 26, 2024
@sydneywalcoff sydneywalcoff added size: 1pt can be done in 6 hours or less issue level I: request Smallest type of issue; Typically can be completed by one person and removed size: 3pt Can be done in 13-18 hours issue level II: main issue tracking level I issues; often will be tracking cross-fuctional teams tasks ready for dev lead task ready for dev lead to evaluate labels Apr 26, 2024
@sydneywalcoff sydneywalcoff changed the title Create code for LG - periods and capitalizations autodetect Code auto-correct missing periods and capitalizations Apr 26, 2024
@davidwiese davidwiese self-assigned this May 10, 2024
Copy link

Hey @davidwiese! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

@davidwiese
Copy link
Member

davidwiese commented May 10, 2024

e- had some personal stuff this week

ETC: Weds 5/22

@davidwiese
Copy link
Member

PR here-

#1407

Copy link

Hey @davidwiese! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@davidwiese
Copy link
Member

Updated PR

Copy link

Hey @davidwiese! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

Copy link

Hey @davidwiese! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@sydneywalcoff sydneywalcoff mentioned this issue Jun 27, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in P: EA: Project Board Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: letter generator issue level I: request Smallest type of issue; Typically can be completed by one person priority: medium role: development anything related to code size: 1pt can be done in 6 hours or less Status: Update Requested
Projects
Development

Successfully merging a pull request may close this issue.

3 participants