Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Terraform Plan GitHub action #31

Closed
2 of 3 tasks
Tyson-miller opened this issue Nov 16, 2023 · 4 comments
Closed
2 of 3 tasks

Create Terraform Plan GitHub action #31

Tyson-miller opened this issue Nov 16, 2023 · 4 comments
Assignees
Labels

Comments

@Tyson-miller
Copy link
Member

Tyson-miller commented Nov 16, 2023

Overview

When we make changes to terraform modules it would be helpful to see the terraform plan as part of the PR so that people can confirm that the resources that would be created/modified/destroyed make sense.

Action Items

  • make a AWS user with the necessary permissions to be able to terraform plan and create credentials (key, secret)
  • Put those credentials into the incubator GitHub secrets
  • Create a GitHub action to run on all PRs to plan the terraform for directories within terraform-incubator that have been modified.

Resources/Instructions

https://github.com/marketplace/actions/terraform-plan - marketplace action for terraform plan
https://github.com/marketplace/actions/changed-files - marketplace action for files changed

@Tyson-miller Tyson-miller added complexity: missing This label means the issue is missing a complexity label role: missing feature: missing size: missing labels Nov 16, 2023
@Tyson-miller
Copy link
Member Author

There is already a user in AWS called github-action-incubator with the secrets stored in the repo and the permissions to run terraform plan so step 1 and 2 should both be done

@Tyson-miller
Copy link
Member Author

Tyson-miller commented Nov 16, 2023

The only potentially tricky feature to implement will be detecting which terraform modules actually changed and running the terraform plan for each module that changed. For example, if someone makes changes to people-depot/dev, vrms-backend/dev, vrms-backend/live in one PR then the action should run the terraform plan for all of those directories.

Otherwise this is a pretty straightforward task

@bonniewolfe bonniewolfe added feature: GHA role: Dev Ops Engineer Engineer who maintains and deploys software and removed feature: missing role: missing labels Nov 16, 2023
@robinglov robinglov added complexity: small and removed complexity: missing This label means the issue is missing a complexity label labels Nov 16, 2023
@ExperimentsInHonesty
Copy link
Member

@Tyson-miller Please add a size label.

@chelseybeck
Copy link
Member

Closed w/ this pr: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants