Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json resume theme path must contain jsonresume-theme- somewhere #173

Closed
ael-code opened this issue Oct 20, 2016 · 2 comments
Closed

Json resume theme path must contain jsonresume-theme- somewhere #173

ael-code opened this issue Oct 20, 2016 · 2 comments
Assignees
Milestone

Comments

@ael-code
Copy link
Contributor

I'm trying to pass an absolute path as --theme argument.
First I discovered that you cannot use path that contains uppercase letters #172 and then I found that the path to a jsonresume theme must contain the string "jsonresume-theme-" somewhere.

In fact in the _loadTheme there is the following check.

  # Create a FRESH or JRS theme object
  theTheme =
    if _opts.theme.indexOf('jsonresume-theme-') > -1
then new JRSTheme().open(tFolder) else new FRESHTheme().open( tFolder );

This constraint is not specified anywhere in the docs and it seems to me a very bad way to recognize the type of the theme. In fact it make impossible to use a generic path for a jsonresume theme.

@ael-code ael-code changed the title Json resume theme path must contain "jsonresume-theme-" somewhere Json resume theme path must contain jsonresume-theme- somewhere Oct 20, 2016
@hacksalot
Copy link
Owner

Yeah, that's ugly. Once upon a time we only supported certain predefined JRS themes IIRC. We'll roll this into 1.9.0.

@hacksalot
Copy link
Owner

Fixed in 231357b.

@hacksalot hacksalot reopened this Jan 31, 2018
@hacksalot hacksalot removed the willfix label Feb 1, 2018
@hacksalot hacksalot self-assigned this Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants