Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md with latest LLVM v13 toolchain. #6420

Closed
derek-gerstmann opened this issue Nov 15, 2021 · 11 comments
Closed

Update README.md with latest LLVM v13 toolchain. #6420

derek-gerstmann opened this issue Nov 15, 2021 · 11 comments
Labels
documentation Missing, incorrect, or unclear. Spelling & grammar mistakes.

Comments

@derek-gerstmann
Copy link
Contributor

Now that LLVM/Clang v13 is out, we should probably update the README.md to indicate the currently supported toolchains and configs to match.
@derek-gerstmann derek-gerstmann added the documentation Missing, incorrect, or unclear. Spelling & grammar mistakes. label Nov 15, 2021
@alexreinking
Copy link
Member

Are you referring to the https://github.com/halide/Halide#platform-support section? That isn't tied to the LLVM release, but to the buildbot hardware.

@derek-gerstmann
Copy link
Contributor Author

Ah, okay! So we don't officially build against v13?

@alexreinking
Copy link
Member

Our first-party binary releases of Halide N are built against LLVM N, but LLVM N±1 are supported. I don't think that's documented in the README anywhere.

@derek-gerstmann
Copy link
Contributor Author

Ahhh ... so the officially supported toolchains are the lowest common stable version, but we build N+1 for releases too. Makes sense.

@derek-gerstmann
Copy link
Contributor Author

Also, I just noticed that the drop of LLVM v11 support (and associated updates to docs) occurred after the v13 release which is what I was looking at, so the doc changes I was originally suggesting are already done. Sorry for the noise.

@alexreinking
Copy link
Member

Also, I just noticed that the drop of LLVM v11 support (and associated updates to docs) occurred after the v13 release which is what I was looking at, so the doc changes I was originally suggesting are already done. Sorry for the noise.

Not noise! Those should be included in the 13.0.1 backport if they're not already.

@derek-gerstmann
Copy link
Contributor Author

derek-gerstmann commented Nov 15, 2021 •
edited
Loading

Oooh ... okay! Should I backport #6396 too?

@alexreinking
Copy link
Member

Oooh ... okay! Should I backport #6396 too?

Couldn't hurt!

@steven-johnson
Copy link
Contributor

Oooh ... okay! Should I backport #6396 too?

Couldn't hurt!

A dissenting opinion: don't bother. There were followup changes that were ticklish to get right. We don't want to backport things that aren't bug fixes, and this isn't that.

@derek-gerstmann
Copy link
Contributor Author

Good point. I was hesitant to make any significant changes, and if this goes beyond docs, then I'd suggest we hold off for a minor release.

@alexreinking
Copy link
Member

A dissenting opinion: don't bother. There were followup changes that were ticklish to get right. We don't want to backport things that aren't bug fixes, and this isn't that.

A very reasonable dissent 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Missing, incorrect, or unclear. Spelling & grammar mistakes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexreinking @steven-johnson @derek-gerstmann