Ref types error

[solerf]

I've got a case that fails validating the default when reading an avro schema with ref types and it has a default:
avro: invalid default for field X. <nil> not a <ref>

fails at isValidDefault from schema.go:1268 since Ref is not handled.

Simple test to reproduce:

package main

import (
	"fmt"
	"github.com/hamba/avro/v2"
)

type MyType struct {
	a int64  `avro:"a"`
	b string `avro:"b"`
}

type TheAvro struct {
	fieldA MyType `avro:fieldA`
	fieldB MyType `avro:fieldB`
}

func main() {
	s, err := avro.Parse(`{
				  "type": "record",
				  "name": "TheAvro",
				  "namespace": "org.testing",
				  "fields": [
					{
					  "name": "fieldA",
					  "type": {
						"type": "record",
						"name": "MyType",
						"fields": [
						  {
							"name": "a",
							"type": "int",
							"default": 0
						  },
						  {
							"name": "b",
							"type": "string",
							"default": "the_default"
						  }
						]
					  },
					  "default": {
						"a": 0,
						"b": "the_default"
					  }
					},
					{
					  "name": "fieldB",
					  "type": "MyType",
					  "default": {
						"a": 0,
						"b": "the_default"
					  }
					}
				  ]
				}
	`)

	if err != nil {
		fmt.Println(err)
	}

	fmt.Println(s) // nil
}

[nrwiersma]

Fixed in v2.10.0

[solerf]

I was trying a fix at schema.go:595 to pass the actual when validating (appeared to work) but you were fast! appreciated!

[nrwiersma]

A ref can be any named schema, so it is better to re-parse the actual rather than assume it is a Record (which it mostly is).