Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does this "container" require jquery 2.1.x? #40

Open
julkue opened this issue Sep 11, 2015 · 7 comments
Open

Why does this "container" require jquery 2.1.x? #40

julkue opened this issue Sep 11, 2015 · 7 comments

Comments

@julkue
Copy link

julkue commented Sep 11, 2015

No description provided.

@arschmitz
Copy link

@julmot it does not this should be updated in the package.json

@piotr-cz
Copy link

piotr-cz commented Apr 3, 2016

plugin works fine with jQuery v1.12.2.
I'm not a npm expert, but I guess package author had to pick some jQuery version and v^2 is fair choice

@julkue
Copy link
Author

julkue commented Apr 3, 2016

>1 should be enough.

@piotr-cz
Copy link

piotr-cz commented Apr 3, 2016

I wonder if * would work

@julkue
Copy link
Author

julkue commented Apr 3, 2016

yes, this works, but I don't think that should be used.

@piotr-cz
Copy link

piotr-cz commented Apr 3, 2016

so what about >=1.12.0 <3.0.0 ?

@felorhik
Copy link

Using jQuery 3 with this causes webpack (not sure if the same thing happens with browserify) to add jQuery 2 alongside jQuery 3, bloating the JS file generated considerably.

If there is no compatibility problem then it should be updated to use the local version of jQuery.
#42 looks like it does this #41 looks like it helps as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants