From b92589a3b0b6e9f29413b1ec0fdaf715c35ef71f Mon Sep 17 00:00:00 2001
From: Nils Knappmeier <github@knappi.org>
Date: Sun, 17 Feb 2019 22:03:15 +0100
Subject: [PATCH] test: add test for NodeJS compatibility

The test is a simple addition to the existing tests. It should ensure
that the built Handlebars artifact only uses language features that are
available in old versions of NodeJS. A simple program and the
precompiler are started with NodeJS 0.10 to 11
---
 .travis.yml                         |   1 +
 Gruntfile.js                        |   3 +-
 multi-nodejs-test/.eslintrc.js      | 114 ++++++++++++++++++++++++++++
 multi-nodejs-test/expected.txt      |   1 +
 multi-nodejs-test/run-handlebars.js |  13 ++++
 multi-nodejs-test/run-tests.sh      |  21 +++++
 multi-nodejs-test/template.txt.hbs  |   1 +
 7 files changed, 153 insertions(+), 1 deletion(-)
 create mode 100644 multi-nodejs-test/.eslintrc.js
 create mode 100644 multi-nodejs-test/expected.txt
 create mode 100755 multi-nodejs-test/run-handlebars.js
 create mode 100755 multi-nodejs-test/run-tests.sh
 create mode 100644 multi-nodejs-test/template.txt.hbs

diff --git a/.travis.yml b/.travis.yml
index ce9690a9c..b8c200dd2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -3,6 +3,7 @@ before_install:
 - npm install -g grunt-cli
 script:
 - grunt --stack travis
+- multi-nodejs-test/run-tests.sh 0.10 0.12 4 5 6 7 8 9 10 11
 email:
   on_failure: change
   on_success: never
diff --git a/Gruntfile.js b/Gruntfile.js
index 7542a7ffc..ff89c737d 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -12,7 +12,8 @@ module.exports = function(grunt) {
         'bench/**/*.js',
         'tasks/**/*.js',
         'lib/**/!(*.min|parser).js',
-        'spec/**/!(*.amd|json2|require).js'
+        'spec/**/!(*.amd|json2|require).js',
+        'multi-nodejs-test/*.js'
       ]
     },
 
diff --git a/multi-nodejs-test/.eslintrc.js b/multi-nodejs-test/.eslintrc.js
new file mode 100644
index 000000000..6d3592c7b
--- /dev/null
+++ b/multi-nodejs-test/.eslintrc.js
@@ -0,0 +1,114 @@
+module.exports = {
+  "extends": "eslint:recommended",
+  "globals": {
+    "self": false
+  },
+  "env": {
+    "node": true
+  },
+  "rules": {
+    // overrides eslint:recommended defaults
+    "no-sparse-arrays": "off",
+    "no-func-assign": "off",
+    "no-console": "off",
+    "no-debugger": "warn",
+    "no-unreachable": "warn",
+
+    // Possible Errors //
+    //-----------------//
+    "no-unsafe-negation": "error",
+
+
+    // Best Practices //
+    //----------------//
+    "curly": "error",
+    "default-case": "warn",
+    "dot-notation": ["error", { "allowKeywords": false }],
+    "guard-for-in": "warn",
+    "no-alert": "error",
+    "no-caller": "error",
+    "no-div-regex": "warn",
+    "no-eval": "error",
+    "no-extend-native": "error",
+    "no-extra-bind": "error",
+    "no-floating-decimal": "error",
+    "no-implied-eval": "error",
+    "no-iterator": "error",
+    "no-labels": "error",
+    "no-lone-blocks": "error",
+    "no-loop-func": "error",
+    "no-multi-spaces": "error",
+    "no-multi-str": "warn",
+    "no-global-assign": "error",
+    "no-new": "error",
+    "no-new-func": "error",
+    "no-new-wrappers": "error",
+    "no-octal-escape": "error",
+    "no-process-env": "error",
+    "no-proto": "error",
+    "no-return-assign": "error",
+    "no-script-url": "error",
+    "no-self-compare": "error",
+    "no-sequences": "error",
+    "no-throw-literal": "error",
+    "no-unused-expressions": "error",
+    "no-warning-comments": "warn",
+    "no-with": "error",
+    "radix": "error",
+    "wrap-iife": "error",
+
+
+    // Variables //
+    //-----------//
+    "no-catch-shadow": "error",
+    "no-label-var": "error",
+    "no-shadow-restricted-names": "error",
+    "no-undef-init": "error",
+    "no-use-before-define": ["error", "nofunc"],
+
+
+    // Stylistic Issues //
+    //------------------//
+    "comma-dangle": ["error", "never"],
+    "quote-props": ["error", "as-needed", { "keywords": true, "unnecessary": false }],
+    "brace-style": ["error", "1tbs", { "allowSingleLine": true }],
+    "camelcase": "error",
+    "comma-spacing": ["error", { "before": false, "after": true }],
+    "comma-style": ["error", "last"],
+    "consistent-this": ["warn", "self"],
+    "eol-last": "error",
+    "func-style": ["error", "declaration"],
+    "key-spacing": ["error", {
+      "beforeColon": false,
+      "afterColon": true
+    }],
+    "new-cap": "error",
+    "new-parens": "error",
+    "no-array-constructor": "error",
+    "no-lonely-if": "error",
+    "no-mixed-spaces-and-tabs": "error",
+    "no-nested-ternary": "warn",
+    "no-new-object": "error",
+    "no-spaced-func": "error",
+    "no-trailing-spaces": "error",
+    "no-extra-parens": ["error", "functions"],
+    "quotes": ["error", "single", "avoid-escape"],
+    "semi": "error",
+    "semi-spacing": ["error", { "before": false, "after": true }],
+    "keyword-spacing": "error",
+    "space-before-blocks": ["error", "always"],
+    "space-before-function-paren": ["error", { "anonymous": "never", "named": "never" }],
+    "space-in-parens": ["error", "never"],
+    "space-infix-ops": "error",
+    "space-unary-ops": "error",
+    "spaced-comment": ["error", "always", { "markers": [","] }],
+    "wrap-regex": "warn",
+
+    // ECMAScript 6 //
+    //--------------//
+    "no-var": "off"
+  },
+  "parserOptions": {
+    "sourceType": "module"
+  }
+}
\ No newline at end of file
diff --git a/multi-nodejs-test/expected.txt b/multi-nodejs-test/expected.txt
new file mode 100644
index 000000000..19a4be2d7
--- /dev/null
+++ b/multi-nodejs-test/expected.txt
@@ -0,0 +1 @@
+Author: Yehuda
diff --git a/multi-nodejs-test/run-handlebars.js b/multi-nodejs-test/run-handlebars.js
new file mode 100755
index 000000000..58bc8d495
--- /dev/null
+++ b/multi-nodejs-test/run-handlebars.js
@@ -0,0 +1,13 @@
+// This test should run with node 0.10 as long as Handlebars has been compiled before
+var Handlebars = require('../');
+var fs = require('fs');
+
+console.log('Testing build Handlebars with Node version ' + process.version);
+var template = fs.readFileSync(require.resolve('./template.txt.hbs'), 'utf-8');
+var compiledOutput = Handlebars.compile(template)({author: 'Yehuda'}).trim();
+var expectedOutput = fs.readFileSync(require.resolve('./expected.txt'), 'utf-8').trim();
+
+if (compiledOutput !== expectedOutput) {
+    throw new Error('Compiled output (' + compiledOutput + ') did not match expected output (' + expectedOutput + ')');
+}
+console.log('Success');
diff --git a/multi-nodejs-test/run-tests.sh b/multi-nodejs-test/run-tests.sh
new file mode 100755
index 000000000..174a12ccb
--- /dev/null
+++ b/multi-nodejs-test/run-tests.sh
@@ -0,0 +1,21 @@
+#!/bin/bash
+
+cd "$( dirname "$( readlink -f "$0" )" )"
+[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
+
+# This script tests with precompiler and the built distribution with multiple NodeJS version.
+# The rest of the travis-build will only work with newer NodeJS versions, because the build
+# tools don't support older versions.
+# However, the built distribution should work with older NodeJS versions as well.
+# This test is simple by design. It merely ensures, that calling Handlebars does not fail with old versions.
+# It does (almost) not test for correctness, because that is already done in the mocha-tests.
+# And it does not use any NodeJS based testing framwork to make this part independent of the Node version.
+
+# A list of NodeJS versions is expected as cli-args
+echo "Handlebars should be able to run in various versions of NodeJS"
+for i in "$@" ; do
+    nvm install "$i"
+    nvm exec "$i" node ./run-handlebars.js >/dev/null || exit 1
+    nvm exec "$i" node ../bin/handlebars template.txt.hbs >/dev/null || exit 1
+    echo Success
+done
\ No newline at end of file
diff --git a/multi-nodejs-test/template.txt.hbs b/multi-nodejs-test/template.txt.hbs
new file mode 100644
index 000000000..61d4dd7fa
--- /dev/null
+++ b/multi-nodejs-test/template.txt.hbs
@@ -0,0 +1 @@
+Author: {{author}}