Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hip-2: update security for valid addresses #35

Open
pinheadmz opened this issue Aug 4, 2021 · 1 comment
Open

hip-2: update security for valid addresses #35

pinheadmz opened this issue Aug 4, 2021 · 1 comment

Comments

@pinheadmz
Copy link
Member

We discussed this in dev chat, that hip2 names should always be prefixed with @ so the user (and wallet software) knows its not intended to be a valid address. Also I think if the string is a valid address (even with the @ included) then hip2 resolution should be aborted.
@Falci
Copy link
Member

Falci commented Aug 4, 2021

We have some sort of consensus about it already. I guess we can jump to a PR and comment there.

@pinheadmz pinheadmz mentioned this issue Aug 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Falci @pinheadmz