Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getwork is wrong and submitwork is missing #127

Open
pinheadmz opened this issue Jun 15, 2021 · 4 comments
Open

getwork is wrong and submitwork is missing #127

pinheadmz opened this issue Jun 15, 2021 · 4 comments

Comments

@pinheadmz
Copy link
Member

getwork in hsd does NOT accept any parameters. It used to in bcoin -- this is probably also why submitwork is missing, it was never included in the bcoin api-docs either.

@delphian
Copy link

hs-miner is attempting to submit ['00000000000000000000000000000000'] as the param value to /getwork on startup, which is resulting in the API returning a -1 error. What am I doing wrong, or what is the proper use of this api endpoint?

@pinheadmz
Copy link
Member Author

@delphian your comment really belongs in the https://github.com/handshake-org/hs-miner repo.

In handshake-org/hsd#583 we removed the arguments to getwork which is why hs-miner is failing for you. I guess #583 made hs-miner outdated, and now that package needs to be updated. Please open an issue there or a pull request! It should be an easy fix.

@delphian
Copy link

@pinheadmz Thanks for clarifying that the docs are correct. I'll take this to hs-miner.

@pinheadmz
Copy link
Member Author

@delphian the docs are incorrect, thats why this issue is still open. hs-miner needs to be updated still as well. The change happened in hsd and all this other stuff is waiting to catch up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants