fix: make conditional compilation of tests depend on var content (#311)

lakekeeper · Aug 29, 2024 · 79036db · 79036db
1 parent 475db44
commit 79036db
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/iceberg-catalog/Cargo.toml b/crates/iceberg-catalog/Cargo.toml
@@ -80,6 +80,6 @@ veil = { workspace = true }
 
 [dev-dependencies]
 http-body-util = { workspace = true }
-needs_env_var = { workspace = true }
+needs_env_var = { git = "https://github.com/twuebi/needs_env_var.git", rev = "bf14242" }
 tower = { workspace = true }
 tracing-subscriber = { workspace = true }
diff --git a/crates/iceberg-catalog/src/implementations/kv2.rs b/crates/iceberg-catalog/src/implementations/kv2.rs
@@ -257,7 +257,7 @@ fn secret_ident_to_key(secret_id: SecretIdent) -> String {
 mod tests {
     use needs_env_var::needs_env_var;
 
-    #[needs_env_var(TEST_KV2)]
+    #[needs_env_var(TEST_KV2 = 1)]
     mod kv2 {
         use crate::service::storage::{S3Credential, StorageCredential};
         use crate::CONFIG;

diff --git a/crates/iceberg-catalog/src/service/storage/az.rs b/crates/iceberg-catalog/src/service/storage/az.rs
@@ -742,7 +742,7 @@ mod test {
     use super::*;
     use needs_env_var::needs_env_var;
 
-    #[needs_env_var(TEST_AZURE)]
+    #[needs_env_var(TEST_AZURE = 1)]
     mod azure_tests {
         use crate::service::storage::{AzCredential, AzdlsProfile};
         use crate::service::storage::{StorageCredential, StorageProfile};

diff --git a/crates/iceberg-catalog/src/service/storage/s3.rs b/crates/iceberg-catalog/src/service/storage/s3.rs
@@ -859,7 +859,7 @@ mod test {
         assert_eq!(location.to_string(), expected);
     }
 
-    #[needs_env_var(TEST_MINIO)]
+    #[needs_env_var(TEST_MINIO = 1)]
     mod minio {
         use crate::service::storage::{
             S3Credential, S3Flavor, S3Profile, StorageCredential, StorageProfile,
@@ -897,7 +897,7 @@ mod test {
         }
     }
 
-    #[needs_env_var(TEST_AWS)]
+    #[needs_env_var(TEST_AWS = 1)]
     mod aws {
         use crate::service::storage::{StorageCredential, StorageProfile};