Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kv2): extend docs & fix mismatch between docs and expected envs #224

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

twuebi
Copy link
Contributor

@twuebi twuebi commented Jul 31, 2024

  1. add quickstart & vault section to developer guide
  2. rename vault to kv2 in a few spots where we missed it in feat(secrets): add support for kv2 secret storage #192, before, the envs described in README.md didn't match what the app expected, I've chosen to align the app to the readme as we're specifically interfacing with the kv2 api, this may be considered breaking

@twuebi twuebi requested a review from c-thiel July 31, 2024 13:16
@twuebi twuebi merged commit be3e3e6 into main Jul 31, 2024
13 checks passed
@twuebi twuebi deleted the tp/kv2-fixes branch July 31, 2024 13:29
@c-thiel c-thiel mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants