fix: make conditional compilation of tests depend on var content #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-thiel
previously approved these changes
Aug 29, 2024
twuebi
force-pushed
the
tp/needs-env-var
branch
from
40d9537
to
c729e8b
Compare
c-thiel
approved these changes
Aug 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, we have failures in CI for non-maintainer PRs (#309), this is due to
needs_env_varchecking for absence / presence of an env while github actions ends up mounting an empty secret for non-maintainer PRs. This PR moves us from crates.ioneeds_env_varto a fork.There's a PR at
needs_env_varto upstream the matching logic: HerrMuellerluedenscheid/needs_env_var#2