Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie MaxAge set incorrectly #614

Closed
aktang opened this issue Mar 2, 2013 · 0 comments · Fixed by #616
Closed

Cookie MaxAge set incorrectly #614

aktang opened this issue Mar 2, 2013 · 0 comments · Fixed by #616
Assignees
Labels
bug Bug or defect
Milestone

Comments

@aktang
Copy link

aktang commented Mar 2, 2013

The cookie Max-Age is getting set incorrectly. When I set a cookie with a ttl of "10000" (in ms), I would expect a Max-Age of "10" (in seconds), but it's setting "10000". The "Expires" attribute is set right (now + 10 secs), but Max-Age apparently takes precedence (at least in Chrome).

req.reply.payload(html).state("mycookie", "xyz", {ttl:10000}).send();

results in the following cookie:

mycookie=xyz; Max-Age=10000; Expires=Sat, 02 Mar 2013 00:35:36 GMT

Found in 0.14.2

@ghost ghost assigned hueniverse Mar 2, 2013
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants