Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use diffWordsWithSpace instead of diffWords in the console reporter #1055

Open
icetbr opened this issue Jul 20, 2022 · 0 comments
Open

Use diffWordsWithSpace instead of diffWords in the console reporter #1055

icetbr opened this issue Jul 20, 2022 · 0 comments
Labels
support Questions, discussions, and general support

Comments

@icetbr
Copy link

icetbr commented Jul 20, 2022

Support plan

  • is this issue currently blocking your project? (yes/no): no
  • is this issue affecting a production system? (yes/no): yes

Context

  • node version: 16.7.0
  • module version with issue: 24.3.2
  • last module version without issue: none
  • environment (e.g. node, browser, native): node
  • used with (e.g. hapi application, another framework, standalone, ...): hapi
  • any other relevant information: I think it's due to a bug diffWords is not ignoring white space kpdecker/jsdiff#236

What are you trying to achieve or the steps to reproduce?

I believe it would be more helpful if white space were to be colored to indicate changes. This is even more problematic when a non break space is in the place of a regular space, so that you can't even see "two spaces" vs "one space"

    test.only('default', async (done) => {
        expect('word1 word2 word3').to.equal('word1  word2 word4')
    });

What was the result you got?

image

What result did you expect?

image

@icetbr icetbr added the support Questions, discussions, and general support label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support Questions, discussions, and general support
Projects
None yet
Development

No branches or pull requests

1 participant