Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find Dockerfile on Windows #77

Open
ghost opened this issue Feb 6, 2018 · 3 comments
Open

Cannot find Dockerfile on Windows #77

ghost opened this issue Feb 6, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Feb 6, 2018

Running captain on Windows with or without captain.yml file gives the error API error (500): {"message":"Cannot locate specified Dockerfile: Dockerfile"}.

After some digging into the code, I found that the error is in the go-dockerclient library https://github.com/fsouza/go-dockerclient/issues/589. But since that issue has been open since Sep. 2016 with no movement, I'm wondering if there is a way to fix the issue on captain's end.

As a workaround, I found that using the "escape hatch" code for Circle CI by helps bypass the issue.

@dkapanidis
Copy link
Member

dkapanidis commented Feb 6, 2018

We need to wait for the fix upstream, but as you said since the 'escape hatch' is working properly maybe we can focus on that:

The CIRCLECI flag is basically a fix that uses the system's docker binary instead of the internal client library. Maybe we can graduate the flag as something on it's own (e.g. CAPTAIN_USE_DOCKER_BINARY)

Then we can set the flag's default value to be true on CircleCI and Windows at least until the issue is fixed.

@ghost
Copy link
Author

ghost commented Feb 6, 2018

Seems like a reasonable solution until they fix in the upstream. Thanks.

@ghost
Copy link
Author

ghost commented Feb 12, 2018

@Spiddy Looks like they fixed the issue upstream fsouza/go-dockerclient@fcb9d66.

I did a Windows build of Captain using the newest version of the library and it fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant