Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Text No Longer Cyan in Reader Mode after Obsidian 0.15.6 Update #23

Closed
muya opened this issue Jul 14, 2022 · 8 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@muya
Copy link

muya commented Jul 14, 2022

Description

After upgrading to Obsidian 0.15.6, the headers in Reader mode are no longer cyan in colour; instead, they are gray, similar to the main text

Steps To Reproduce

  • Create a new vault in Obsidian 0.15.6
  • Install the Solarized theme from the "Appearance" section under preferences
  • Create a new note
  • Add one or more Header markdown sections:
# H1 Header
Some text

## H2 Header

H1 Header Content in Editing Mode

- Switch to "Reader Mode"

Expected

  • In "Reader Mode", the headers should be in colour "cyan"

Actual

  • In "Reader Mode", the headers are also in colour "gray", similar to the text

H1 Header Content in Reader Mode

Environment Details

OS Version: macOS 12.4
Obsidian Version: Version 0.15.6 (installer 0.14.15)
Solarized Theme Version: Latest
@carlosasterisk
Copy link

I have the same problem in the latest version 0.15.6. In reader mode, the header is in cyan. What can I do to fix it? Thank you!

@iancustoica
Copy link

iancustoica commented Aug 11, 2022

Hello,

Before reading on please note I do not work with css so my fix might not be the best or most elegant solution.

I have the same issue with this theme after updating obsidian and even though I do not understand the root cause I made a fix for it by looking at another theme and pasting some code that controls headings (1-6) properties. I focused only on the light theme, so if you just want the same color (cyan) for every heading you need to manually change the variables from for ex: "color: var(--text-title-h5) !important;" to "color: var(--text-title) !important;"

I suggest you create a new css file in your obsidian vault/.obsidian/themes and experiment with it so if the solarized theme gets updated you won't have any problems or conflicts.

Here's a gist of my changes, hope it helps:

https://gist.github.com/iancustoica/7f6e7095a8bf6a74aec2497d9e40a587

@marchank0
Copy link

I made a pull request with a fix
for now you may add this code into css

[data-heading] {
    color: var(--text-title) !important;
}

@muya
Copy link
Author

muya commented Oct 9, 2022

I made a pull request with a fix for now you may add this code into css

[data-heading] {
    color: var(--text-title) !important;
}

Nice, @marchank0 - this is working 👍🏽

@carlosasterisk
Copy link

I made a pull request with a fix for now you may add this code into css

[data-heading] {
    color: var(--text-title) !important;
}

Does it work for Inline title?

@marchank0
Copy link

@carlosasterisk
could you please provide example in md format to check what do you mean?

@harmtemolder
Copy link
Owner

Should be fixed with the new release. Could you test, please?

@muya
Copy link
Author

muya commented Nov 22, 2022

Should be fixed with the new release. Could you test, please?

@harmtemolder This seems to be working - thank you so much!

@muya muya closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants