Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check compatibility with Split v1.1.0 #2

Open
andrew opened this issue Jan 10, 2015 · 1 comment
Open

Check compatibility with Split v1.1.0 #2

andrew opened this issue Jan 10, 2015 · 1 comment

Comments

@andrew
Copy link

andrew commented Jan 10, 2015

Just a heads up really, yesterday I released v1.1.0 of Split which included some internal refactoring that you may rely on in this extension so you may want to check that it's not broken anything.
@danielschwartz
Copy link
Contributor

@andrew sorry for the crazy delay in writing back, and thanks for the heads up! I haven't officially checked that this should work (though I will hopefully have time to quickly do this tomorrow). The main method I use internally are Split::ExperimentCatalog.find and ab_test so I think it should be ok. Ill upgrade to the latest version of split and run our tests locally just to make sure though.

@werkshy werkshy mentioned this issue Mar 14, 2016
Merged
@irubnich irubnich mentioned this issue Mar 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrew @danielschwartz