Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isComparable full interface check #701

Merged
merged 2 commits into from
May 24, 2024
Merged

fix: isComparable full interface check #701

merged 2 commits into from
May 24, 2024

Conversation

GuillermoCasalCaro
Copy link
Contributor

@GuillermoCasalCaro GuillermoCasalCaro commented May 23, 2024 •
edited
Loading

Summary

This pull request enhances the isComparable function to ensure it fully implements the Comparable interface, which includes the methods equals, gt, geq, lt, and leq.

Enhancement of isComparable Function

The isComparable function has been improved to check for the complete implementation of the Comparable interface. This ensures that the function correctly identifies objects that are meant to be compared using the methods of the Comparable interface.

  • Modified File: src/drop/comparable.ts
  • Function Modified: isComparable

Related Issues

Fixes #700

@GuillermoCasalCaro GuillermoCasalCaro changed the title Is comparable full interface check fix: isComparable full interface check May 23, 2024
@harttle harttle merged commit 55e144a into harttle:master May 24, 2024
13 of 14 checks passed
@harttle
Copy link
Owner

harttle commented May 24, 2024

@all-contributors please add @GuillermoCasalCaro for code

@allcontributors allcontributors bot mentioned this pull request May 24, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@harttle

I've put up a pull request to add @GuillermoCasalCaro! 🎉

github-actions bot pushed a commit that referenced this pull request May 24, 2024
@semantic-release-bot
chore(release): 10.13.1 [skip ci]
513940d 
## [10.13.1](v10.13.0...v10.13.1) (2024-05-24)

### Bug Fixes

* allow liquidMethodMissing to return any supported value type ([#698](#698)) ([0983f2c](0983f2c))
* isComparable full interface check ([#701](#701)) ([55e144a](55e144a))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 10.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bossazizan bossazizan mentioned this pull request Jun 18, 2024
Open
@OATEF4313 OATEF4313 mentioned this pull request Jun 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Aug 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance isComparable function for full Comparable interface implementation
2 participants
@GuillermoCasalCaro @harttle