-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do you have Python code #26
Comments
yeah we have it implemented in python as well: http://opennmt.net/OpenNMT-py/im2text.html |
Thank you for your code. And I download the trained model and dataset which the link mentioned. And evaluate it with the test dataset . However the results can not reach the scores mentioned in the paper. |
Hmm interesting. There are some differences between the python code and the lua code, e.g., the batching is different, and the python code is treating images as three channels R,G,B, whereas the lua code converts images to greyscale first which decreases the number of parameters. For reproducing the results in the paper, I'd suggest using the lua code which I'm pretty sure can get the reported accuracy. |
Thanks, I will try to use the lua code. And do you have the model which you have trained by lua code? |
Yes see this section: https://github.com/harvardnlp/im2markup#test |
Oh, yeah. I found it, thank you very much! And by the way, I wonder if the trained model in python is the best one. In other word, if I train it for more time, will it perform better? |
I'm not sure since I trained it years ago... But please let me know if you can get a pytorch model matching the performance of the luatorch one. (I think it might be possible to convert the luatorch model to pytorch if we manually convert all weights) |
Okey, Thank you! |
Thank you very much, and I reproduce the results successfully with lua code. |
closing now, please reopen if there are other problems. |
This http://opennmt.net/OpenNMT-py/im2text.html |
the link has chnaged! check this : |
To be honest, I'm not very familiar with Lua code, so I wish you could have a python implementation. It’s very important for me. Thank you very much
The text was updated successfully, but these errors were encountered: