-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text search doesn't match (@usernames)
#435
Comments
Thanks for the parentheses reference. Would it be necessary for us to specify that @ should be skipped? Would "aseemk" not match "@aseemk"? |
If the @ symbol was not put in the skip array, the regex would only match @asseemk precisely because it starts at the beginning of strings. |
So it wouldn't be possible to match both |
If we applied the replacement to the search string as well as the option, they would match. Right now, it's just applied to the option, so we'll have to take a look at that. Feel free to offer some code solution that handles this case. |
One more quick issue: our
<option>
elements' text looks like "Aseem Kishore (@aseemk)". If I search for "aseem" or "kishore", it matches those parts of the string, but if I type in "aseemk" or "@aseemk", it doesn't work.What do you guys think? Sound like a reasonable thing to support?
The text was updated successfully, but these errors were encountered: