Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text search doesn't match (@usernames) #435

Closed
aseemk opened this issue Jan 10, 2012 · 5 comments
Closed

Text search doesn't match (@usernames) #435

aseemk opened this issue Jan 10, 2012 · 5 comments

Comments

@aseemk
Copy link

aseemk commented Jan 10, 2012

One more quick issue: our <option> elements' text looks like "Aseem Kishore (@aseemk)". If I search for "aseem" or "kishore", it matches those parts of the string, but if I type in "aseemk" or "@aseemk", it doesn't work.

What do you guys think? Sound like a reasonable thing to support?

@pfiller
Copy link
Contributor

pfiller commented Jan 11, 2012

Chosen doesn't skip parentheses when searching yet (see issue #206). #387 would help you skip the @ sign. Hopefully we can get a bunch of these pull requests handled this week.

@pfiller pfiller closed this as completed Jan 11, 2012
@aseemk
Copy link
Author

aseemk commented Jan 11, 2012

Thanks for the parentheses reference.

Would it be necessary for us to specify that @ should be skipped? Would "aseemk" not match "@aseemk"?

@pfiller
Copy link
Contributor

pfiller commented Jan 11, 2012

If the @ symbol was not put in the skip array, the regex would only match @asseemk precisely because it starts at the beginning of strings.

@aseemk
Copy link
Author

aseemk commented Jan 11, 2012

So it wouldn't be possible to match both aseemk and @aseemk in this list? =/

@pfiller
Copy link
Contributor

pfiller commented Jan 11, 2012

If we applied the replacement to the search string as well as the option, they would match. Right now, it's just applied to the option, so we'll have to take a look at that. Feel free to offer some code solution that handles this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants