Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url_for needs to be app-aware #288

Closed
jace opened this issue Nov 19, 2018 · 3 comments
Closed

url_for needs to be app-aware #288

jace opened this issue Nov 19, 2018 · 3 comments

Comments

@jace
Copy link
Member

jace commented Nov 19, 2018

From #230, URLs will vary between the two apps, so the url_for methods in all apps will need to be app-aware. We do this by removing the imperative url_for methods and using the declarative is_url_for decorator on views, supplying it with the app (or use ClassView with UrlForView).

Dependency: hasgeek/coaster#199

@jace jace added this to the HasGeek.com release milestone Nov 19, 2018
@jace
Copy link
Member Author

jace commented Nov 22, 2018

The dependency is now resolved. There may be another dependency on hasgeek/coaster#180 if we switch to ClassView.

@jace
Copy link
Member Author

jace commented Dec 6, 2018

The Coaster dependency is now resolved. Pending task: removing the url_for methods in all classes, switching to UrlForView in class views, and @Model.is_url_for in function views.

@iambibhas this will be part of your view rewrite.

@jace
Copy link
Member Author

jace commented Dec 8, 2018

Resolved with #316.

@jace jace closed this as completed Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant