Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify message SlotKey that the contractID is never an evm address #324

Open
david-bakin-sl opened this issue Jan 30, 2024 · 0 comments
Open

Clarify message SlotKey that the contractID is never an evm address #324

david-bakin-sl opened this issue Jan 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@david-bakin-sl
Copy link
Member

Problem

Current javadoc at SlotKey.contractID isn't clear (IMO!) that the ContractID must be a contractNum and never an evm_address. IMO "number of the contract" doesn't directly relate to the field contractNum and might be taken to simply mean that the "number" is the "ID". Or so I believe.

Solution

Add a sentence saying this explicitly.

Alternatives

No response
@david-bakin-sl david-bakin-sl added the enhancement New feature or request label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@david-bakin-sl