Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign without Freeze does not fail #946

Closed
0xivanov opened this issue Jun 3, 2024 · 0 comments · Fixed by #947
Closed

Sign without Freeze does not fail #946

0xivanov opened this issue Jun 3, 2024 · 0 comments · Fixed by #947
Assignees
@0xivanov
Labels
bug Something isn't working
Milestone
2.38.0

Comments

@0xivanov
Copy link
Contributor

0xivanov commented Jun 3, 2024 •
edited
Loading

Description

Signing requires the transaction to be frozen. We need to make sure the request is frozen before signing. Add check for this and propagate errTransactionIsNotFrozen if the check fails

Steps to reproduce

Sign and execute transaction without freezing.

Additional context

No response

Hedera network

testnet

Version

2.37.0

Operating system

None
@0xivanov 0xivanov added the bug Something isn't working label Jun 3, 2024
@0xivanov 0xivanov self-assigned this Jun 3, 2024
@0xivanov 0xivanov mentioned this issue Jun 3, 2024
Merged
2 tasks
@Petyo-Lukanov Petyo-Lukanov added this to the 2.38.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xivanov 0xivanov

Labels
bug Something isn't working
Projects
None yet
Milestone
2.38.0
Development

Successfully merging a pull request may close this issue.

fix: Raise an error if the transaction is not frozen while signing hashgraph/hedera-sdk-go
2 participants
@0xivanov @Petyo-Lukanov