Fix schedule network recursive call #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamzedev
requested review from
andrix10,
janaakhterov,
mehcode and
SimiHunjan
as code owners
bamzedev
force-pushed
the
fix-schedule-network-recursive-call
branch
from
d521c1f
to
052fb87
Compare
Signed-off-by: Emanuel Pargov <[email protected]>
bamzedev
force-pushed
the
fix-schedule-network-recursive-call
branch
from
052fb87
to
fb0ca7b
Compare
MiroslavGatsanoga
approved these changes
Nov 15, 2022
Signed-off-by: Emanuel Pargov <[email protected]>
bamzedev
force-pushed
the
fix-schedule-network-recursive-call
branch
from
b27f8d7
to
86585a0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
MiroslavGatsanoga
approved these changes
Nov 15, 2022
0xivanov
reviewed
Nov 11, 2024
| Execute(client) | ||
| if err == nil && len(addressbook.NodeAddresses) > 0 { | ||
| client.SetNetworkFromAddressBook(addressbook) | ||
| for { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Emanuel Pargov [email protected]
Description:
Schedule Network update was a recursive call. This PR changes this method in client.go to use a loop instead of recursive call.
In addition also fixes ClientFor/Previewnet/Testnet/Mainnet methods setting the wrong LedgerID.
Related issue(s):
Fixes #619 #624