Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for ** in glob #36

Open
cbednarski opened this issue Jun 9, 2015 · 2 comments
Open

Add explicit support for ** in glob #36

cbednarski opened this issue Jun 9, 2015 · 2 comments
Labels

Comments

@cbednarski
Copy link
Contributor

Glob in Go doesn’t actually work the way it’s tested here:

Include: []string{"build/**/*"},

This test passes in *nix because (I think) the underlying shell takes over and expands the path. However, this doesn't work on Windows, and so is not portable. This is technically a bug in the test but people may be using this in the wild... Do we want to fix it by adding ** support for Windows?

@cbednarski cbednarski changed the title Incorrect use of glob (broken on Windows) Add explicit support for ** in glob Jun 9, 2015
@cbednarski cbednarski changed the title Add explicit support for ** in glob Add explicit support for ** in glob Jun 9, 2015
@cbednarski cbednarski added the bug label Jun 9, 2015
@mitchellh
Copy link
Contributor

Talked about this in Slack but will add context here:

https://hashicorp.slack.com/archives/packer/p1433819316000060

@cbednarski
Copy link
Contributor Author

To recap in the issue, we do want to support this on Windows. Marked as bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants