From 8015066d1eb722c1e7894836c6b18e5635eb457c Mon Sep 17 00:00:00 2001 From: Curt Bushko Date: Mon, 26 Jun 2023 09:49:51 -0400 Subject: [PATCH] remove todos --- acceptance/tests/connect/connect_proxy_lifecycle_test.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/acceptance/tests/connect/connect_proxy_lifecycle_test.go b/acceptance/tests/connect/connect_proxy_lifecycle_test.go index 6ac4382e7c..ecdc51b547 100644 --- a/acceptance/tests/connect/connect_proxy_lifecycle_test.go +++ b/acceptance/tests/connect/connect_proxy_lifecycle_test.go @@ -134,7 +134,6 @@ func TestConnectInject_ProxyLifecycleShutdown(t *testing.T) { connHelper.TestConnectionSuccess(t) // Get static-client pod name - // TODO: is this necessary? ns := ctx.KubectlOptions(t).Namespace pods, err := ctx.KubernetesClient(t).CoreV1().Pods(ns).List( context.Background(), @@ -175,12 +174,9 @@ func TestConnectInject_ProxyLifecycleShutdown(t *testing.T) { }) }) - // TODO: If listener draining is enabled, ensure inbound + // If listener draining is enabled, ensure inbound // requests are rejected during grace period. // connHelper.TestConnectionSuccess(t) - - // TODO: Test that outbound requests start failing after - // shutdown grace period has elapsed but before pod terminates. } else { // Ensure outbound requests fail because proxy has terminated retry.RunWith(&retry.Timer{Timeout: time.Duration(terminationGracePeriod) * time.Second, Wait: 2 * time.Second}, t, func(r *retry.R) {