-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix json tags for fields 1.0.x #2159
fix json tags for fields 1.0.x #2159
Conversation
4c4d211
to
f5257c7
Compare
f5257c7
to
1473d83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint is failing it seems. But otherwise LGTM. Thanks.
Just to add context: This PR is the to fix backport issue which omitted commits from original PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this one for a little bit while I fix some CI errors that should 🤞 make the tests go clear.
I will push through when complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the pipelines!
Checklist: