Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v2 mesh-init command #2941

Merged
merged 9 commits into from
Sep 14, 2023
Merged

feat: v2 mesh-init command #2941

merged 9 commits into from
Sep 14, 2023

Conversation

DanStough
Copy link
Contributor

@DanStough DanStough commented Sep 11, 2023

Changes proposed in this PR:

  • Add a new command mesh-init that replaces connect-init for V2 workloads. This uses the dataplane RPC to get the bootstrap config necessary for IPtables configuration. It also allows the workload time to reconcile in Consul before starting the rest of the pod.
  • Removes the V2 flag from partition-init, since the V1 API will still work for this.
  • Fixes the telemetry-collector for V2, which manually specifies these fields.

ACL Support is planned in the next release.

There is a follow-up task I will make to update all the connect-inject=truthy annotations in helm to also include mesh-inject.

How I've tested this PR: Unit/Integration tests with the Consul test server.

How I expect reviewers to test this PR: 👁️ 🔍

  • I think it would help to go commit-by-commit since this PR has some separate concerns.
  • I would compare this to the behavior of the connect-init command.
  • I would also compare the telemetry V2 changes to the V1 YAML. The tests are identical, except for enabling V2.

Checklist:

@DanStough DanStough added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Sep 11, 2023
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! Nicely done!!

@DanStough DanStough marked this pull request as ready for review September 13, 2023 03:59
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor comments but overall the adaptation of the existing command makes sense to me.

control-plane/subcommand/mesh-init/command_ent_test.go Outdated Show resolved Hide resolved
control-plane/consul/dataplane_client_test.go Outdated Show resolved Hide resolved
control-plane/subcommand/mesh-init/command.go Outdated Show resolved Hide resolved
@DanStough
Copy link
Contributor Author

I see the WANfed acceptance test failing in another commit on main, so I'm going to merge this.

@DanStough DanStough merged commit 38dc912 into main Sep 14, 2023
27 of 31 checks passed
@DanStough DanStough deleted the dans/NET-5316/v2-connect-init branch September 14, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants