NET-5947 Add NET_BIND_SERVICE capability in security context for api-gateway pod on OpenShift #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathancoleman
added
theme/openshift
theme/api-gateway
nathancoleman
changed the title
t-eckert
approved these changes
Oct 12, 2023
nathancoleman
commented
Oct 12, 2023
curtbushko
approved these changes
Oct 12, 2023
nathancoleman
changed the title
nathancoleman
changed the title
nathancoleman
commented
Oct 12, 2023
| @@ -19,7 +18,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| allCapabilities = "all" | |||
| allCapabilities = "ALL" | |||
There was a problem hiding this comment.
This was causing an odd merge when the OpenShift controller added ALL alongside our all since they're not equal strings, resulting in
drop:
- ALL
- all
missylbytes
approved these changes
Oct 12, 2023
nathancoleman
force-pushed
the
api-gateway-net-bind-service
branch
from
650cbbc
to
1b639af
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed:
This capability became a requirement for consul-dataplane, which api-gateway uses under the hood, as of hashicorp/consul-dataplane#238. Since the
securityContextcreated for each consul-dataplanePodwas not requesting theNET_BIND_SERVICEcapability specifically when deploying onto OpenShift, it was not being granted, and thePodwas failing to start with a permission denied error.Changes proposed in this PR:
NET_BIND_SERVICEcapability to thesecurityContextfor each api-gatewayPodHow I've tested this PR:
securityContextis always set appropriately onPodPodstarts up correctly nowHow I expect reviewers to test this PR:
Checklist: