Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): v2 pod controller error log for missing ip #3162

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

DanStough
Copy link
Contributor

Changes proposed in this PR:

  • Fixes an extraneous error log when a pod is first scheduled but not yet allocated an IP.

How I've tested this PR: unit tests and manual integration.

How I expect reviewers to test this PR: 👀

Checklist:

@DanStough DanStough force-pushed the dans/NET-5872/fix-pod-controller-missing-ip-log branch from 57e739c to 54826c5 Compare November 1, 2023 15:40
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@DanStough DanStough merged commit e50c8e2 into main Nov 2, 2023
46 of 48 checks passed
@DanStough DanStough deleted the dans/NET-5872/fix-pod-controller-missing-ip-log branch November 2, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants